fix: clear cache on disable to prevent stale skip on re-enable - #5
Open
liooooo29 wants to merge 1 commit into
Open
fix: clear cache on disable to prevent stale skip on re-enable#5liooooo29 wants to merge 1 commit into
liooooo29 wants to merge 1 commit into
Conversation
disable() deletes all desktop launcher files but leaves the cache intact. On re-enable, rescan() calls addAppImage() which checks the cache, finds stale entries, and skips recreation — permanently losing all desktop icons. Synchronously delete the cache file after removing launchers so that enable() performs a fresh scan and recreates all desktop files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
disable() deletes all desktop launcher files but leaves the cache intact. On re-enable, rescan() calls addAppImage() which checks the cache, finds stale entries, and skips recreation — permanently losing all desktop icons until the user manually clears the cache file.
Steps to reproduce:
Fix
Synchronously delete the cache file after removing launchers in disable(), so that enable() performs a fresh scan and recreates all desktop files.