Repository navigation
fix: keep QUIC connections without streams alive - #181
Merged
Merged
Conversation
gmelodie
force-pushed
the
fix/keepalive
branch
from
October 9, 2026 15:06
af849c0 to
1272014
Compare
richard-ramos
left a comment
richard-ramos
left a comment
Collaborator
There was a problem hiding this comment.
Lets also update the settings.es_ping_period in context/server.nim and client.nim to 15s so we match go-libp2p!
gmelodie
marked this pull request as ready for review
October 9, 2026 18:44
gmelodie
force-pushed
the
fix/keepalive
branch
4 times, most recently
from
October 9, 2026 19:25
c4b8df6 to
5c7f073
Compare
Member
|
/review |
vladopajic
approved these changes
Oct 9, 2026
gmelodie
force-pushed
the
fix/keepalive
branch
from
October 9, 2026 19:55
5c7f073 to
7d2b41e
Compare
richard-ramos
approved these changes
Oct 9, 2026
gmelodie
force-pushed
the
fix/keepalive
branch
from
October 9, 2026 20:15
7d2b41e to
cb1b76b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lsquic arms the client PING alarm in
ietf_full_conn_ci_tickonly while the connection has an open non-special stream. A libp2p connection often has no stream between requests, so it sends no PING and the idle timeout closes it. In a nimbus testnet, such a connection closes after 37 s.This PR bumps
libs/lsquicto iftech/lsquic#2, which arms the alarm wheneveres_ping_periodis set. The new test waits 12 s on a 3 s idle timeout, as stock lsquic sends NEW_CONNECTION_ID frames for 7 s after the handshake.