Repository navigation
Fix: CI + Clang 15 + Claims ordering - #1
Merged
Merged
Conversation
richard-ramos
approved these changes
Mar 27, 2026
nitely
marked this pull request as ready for review
March 28, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
uinttocsize_tin C callbacks to fix clang 15 compilation error: Bump bearssl to 0.2.7 status-im/nim-chronos#624ClaimsTableRef to OrderedTableRef to keep key ordering; mostly for testing. The extra int that OrderedTableRef adds per entry should not matter I think. The test won't pass with TableRef because it generates a different base64. Note Jwt doesn't care about ordering, but using OrderedTableRef should be fine nevertheless.Reproduction of the macos clang 15 error can be found here https://github.com/nitely/nim-jwt/actions/runs/23659607724/job/68926078381 (I ran the test before changing anything but the CI).
todo: fix nimble require that points to my fork before merging; Pending iftech/bearssl_pkey_decoder#1