Add progpow-debug.diff, which outputs digest for a fixed header and nonce#46
Open
solardiz wants to merge 1 commit intoifdefelse:masterfrom
Open
Add progpow-debug.diff, which outputs digest for a fixed header and nonce#46solardiz wants to merge 1 commit intoifdefelse:masterfrom
solardiz wants to merge 1 commit intoifdefelse:masterfrom
Conversation
Owner
|
Instead of checking in a .diff, can you wrap these changes in a #ifdef? |
Contributor
Author
|
I can. Please suggest what to call the macro enabling this debugging mode, and how/where we'd recommend people to set it (when needed). |
Contributor
Author
|
Thinking of this some more, it's a bit complicated: some of the changes are in kernels, so we'd need to pass the macro to kernel builds. I think it's better to check in the .diff for now. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a patch like this in the tree should be better than not having any testing/debugging capabilities at all, although ideally ProgPoW would have this functionality without a need to patch.