allow the specification of options for subscription creation (#20)

idoshamun · Jan 7, 2020 · b3324b6 · b3324b6
1 parent 45432cf
commit b3324b6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -23,11 +23,12 @@ process, you should use [socket.io-emitter](https://github.com/socketio/socket.i
 
 ### adapter(pubsub[, opts])
 
-`pubsub` is a [google-cloud](https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud) [pubsub](https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud/pubsub) object. 
+`pubsub` is a [google-cloud](https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud) [pubsub](https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud/pubsub) object.
 
 The following options are allowed:
 
 - `key`: the topic name of the pub/sub events (`socket.io`)
+- `createSubscriptionOpts`: [options for creating a subscription](https://googleapis.dev/nodejs/pubsub/latest/global.html#CreateSubscriptionRequest)
 
 
 ### PubsubAdapter

diff --git a/lib/index.js b/lib/index.js
@@ -68,6 +68,7 @@ function adapter(pubsub, opts) {
 
     const prefix = opts.key || 'socket.io';
     const uid = `socket.io-${shortid.generate()}`;
+    const createSubscriptionOpts = opts.createSubscriptionOpts || {};
 
     /**
      * PubsubAdapter constructor.
@@ -84,6 +85,7 @@ function adapter(pubsub, opts) {
         this.prefix = prefix;
         this.channel = prefix + '#' + nsp.name + '#';
         this.topics = {};
+        this.createSubscriptionOpts = createSubscriptionOpts;
         this.subscriptions = {};
 
         this.subscribe(this.prefix, () => {
@@ -128,7 +130,7 @@ function adapter(pubsub, opts) {
                 callback(null, topicObj);
             },
 
-            getSubscription.bind(null, this.uid, {})
+            getSubscription.bind(null, this.uid, this.createSubscriptionOpts)
         ], (err, subscription) => {
 
             if (err) {