Chipaton2024. Onchip Team. Current Reference Generator draft PR. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed, working in layout, EA layout at 90 percent, Top layout pending but working on that.
| devices_info = [m1,m2] | ||
|
|
||
|
|
||
| Diff_PairComp = Component() |
There was a problem hiding this comment.
Can the existing diff pair component be reused here? If not, can an argument be added to it to make it reusable?
| length2: float = None, | ||
| fingers1: int = 3, | ||
| fingers2: int = 3, | ||
| matriz: list = [[0,2,1,1,2,0],[0,1,2,2,1,0],[0,2,1,1,2,0],[0,1,2,2,1,0]], |
There was a problem hiding this comment.
These matrices seem to repeat a lot. Can they be converted into constants or a function with some documentation?
|
|
||
| #Creacion de ports | ||
| #GA | ||
| GA_port = idplace.ports['A'+puerto_GA[0]+'_gate_S'] |
There was a problem hiding this comment.
Can code duplication be reduced here? Perhaps by using a loop?
| return component | ||
|
|
||
|
|
||
| def create_tapring_onchip( |
There was a problem hiding this comment.
Can some of these components or functions be converted into separate elementary blocks or primitives? They could be used in other generators.
|
@AlexMantilla1 any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chipaton2024: Onchip Team. Current Reference Generator. Design achieved, working in layout, Error Amplifier layout at 90 percent, Top layout pending but working on that.