Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergoCubSN001: simplify collision shape of feet #180

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Oct 3, 2023

It fixes #179

Moreover, it removes all the default sensors from the ergoCubSN000 yaml, since that clause is not supported by creo2urdf

@Nicogene Nicogene requested a review from traversaro October 3, 2023 14:55
@Nicogene Nicogene self-assigned this Oct 3, 2023
@traversaro
Copy link
Member

Just to understand, what are the other changes related to?

@traversaro
Copy link
Member

cc @akhilsathuluri

@Nicogene
Copy link
Member Author

Nicogene commented Oct 4, 2023

Just to understand, what are the other changes related to?

The changes in the yaml are related to the fact creo2urdf does not support sensorName default clause

@traversaro
Copy link
Member

traversaro commented Oct 4, 2023

Just to understand, what are the other changes related to?

The changes in the yaml are related to the fact creo2urdf does not support sensorName default clause

Ack, can you add a sentence on that in PR description? Thanks! Because as it is the PR seems just relaed to ergoCubSN001, not ergoCubSN000. Other then that this seems fine.

@Nicogene Nicogene merged commit a355a05 into master Oct 4, 2023
@Nicogene Nicogene deleted the feetSimpleShape branch October 4, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use simple collision for foot also for non-Gazebo models
2 participants