Skip to content

fix(zip): use ushort for ITaggedData.TagID #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2021
Merged

fix(zip): use ushort for ITaggedData.TagID #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/ICSharpCode.SharpZipLib/Zip/ZipExtraData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public interface ITaggedData
/// <summary>
/// Get the ID for this tagged data value.
/// </summary>
short TagID { get; }
ushort TagID { get; }

/// <summary>
/// Set the contents of this instance from the data passed.
Expand All @@ -41,7 +41,7 @@ public class RawTaggedData : ITaggedData
/// Initialise a new instance.
/// </summary>
/// <param name="tag">The tag ID.</param>
public RawTaggedData(short tag)
public RawTaggedData(ushort tag)
{
_tag = tag;
}
Expand All @@ -51,7 +51,7 @@ public RawTaggedData(short tag)
/// <summary>
/// Get the ID for this tagged data value.
/// </summary>
public short TagID
public ushort TagID
{
get { return _tag; }
set { _tag = value; }
Expand Down Expand Up @@ -100,7 +100,7 @@ public byte[] Data
/// <summary>
/// The tag ID for this instance.
/// </summary>
private short _tag;
private ushort _tag;

private byte[] _data;

Expand Down Expand Up @@ -139,7 +139,7 @@ public enum Flags : byte
/// <summary>
/// Get the ID
/// </summary>
public short TagID
public ushort TagID
{
get { return 0x5455; }
}
Expand Down Expand Up @@ -328,7 +328,7 @@ public class NTTaggedData : ITaggedData
/// <summary>
/// Get the ID for this tagged data value.
/// </summary>
public short TagID
public ushort TagID
{
get { return 10; }
}
Expand Down