Skip to content

Handle TypeError for is_float #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle TypeError for is_float #157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6137252
Handle TypeError for `is_float`
hiaoxui Apr 1, 2025
836f503
Merge branch 'icometrix:main' into main
hiaoxui May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dicom2nifti/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,6 +1100,9 @@ def is_float(number):
return True
except ValueError:
return False
except TypeError:
# Some types cannot be taken by `float`, such as None.
return False

# only set if it is an actual float, can also be empty/none
if not is_float(repetition_time) or not is_float(echo_time):
Expand Down