Docker compatible with Mac architecture; cleanup dev scripts #395
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoraba
reviewed
Apr 24, 2024
| @@ -1,7 +1,7 @@ | |||
| ################################### | |||
| # Maven Builder | |||
| ################################### | |||
| FROM adoptopenjdk/openjdk11:jdk-11.0.6_10-alpine-slim as builder | |||
| FROM adoptopenjdk/openjdk11:jdk-11.0.6_10-slim as builder | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alpine JDK docker image has compatibility issues with ARM architecture devices (Apple Silicon), switching to a non-alpine base image should provide a bit more stability when running on Macs.
As part of the change, some libraries needed updating due to the old versions no longer being available on Maven. These changes are included as well.