-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 RC 3.43.0 #709
Merged
Merged
🚀 RC 3.43.0 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Back - 3.42.0
…ry and resolver (#700)
…al parameter to dataCenter query by shortName and update resolver to use this function and query (#701)
* commit before branch change * replacing GRPC to HTTP method for public single program, private single program and private program list endpoints * remove comments * add joinProgramInvite http fetch and update resolver. some resolved error remain. git commit before switching branch * fix error from date values and waiting program service to fix first and last name * remove unused key value pairs in joinProgramInvite response * updated name * edit http fetch to match new Program Service api data format * remove testing console.log * implement urljoin * add util.js file to services/programService folder and add authorizationHeader to handle repetive part in fetch header * moved authorizationHeader to a ts file in a new folder, utils * implement logger and updated error message to be specific and detail --------- Co-authored-by: Dan <[email protected]>
… private field. Test the resolver works with dataCenter (#705)
* Test Stubs * Filter for Countries * Use regions * Remove countries from gql definition * Updated DataCenter Filter * Replace region w/ datacenter * Capitalize Center * Unnecessary Empty Line * Change Query to Filter * Skip filtering when no DataCenter * Invert Conditional
demariadaniel
requested review from
joneubank,
justincorrigible and
daniel-cy-lu
and removed request for
joneubank
December 5, 2023 15:46
justincorrigible
previously approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
justincorrigible
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
/profile
handler to storage-api proxy #706 Add /profile HandlerPlatform API -> Program Service
integration to REST API #674 Rest API IntegrationType of Change