Fixing bug with disableDrag with useLongPress + programmatical set disableDrag#59
Open
paamand wants to merge 1 commit intoibrierley:masterfrom
Open
Fixing bug with disableDrag with useLongPress + programmatical set disableDrag#59paamand wants to merge 1 commit intoibrierley:masterfrom
paamand wants to merge 1 commit intoibrierley:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new disableDrag did not work with useLongPress due to wrong logic in the GestureDetector.
Instead, this PR changes the disableDrag to not be final and checks the state in the relevant _start and _pan methods.
This fixes the problem with useLongPress and also allows to set the disableDrag on an existing marker.