linkextractor-api should expose port 5000 only inside container,#11
Open
ldelaprade wants to merge 1 commit intoibnesayeed:step4from
Open
linkextractor-api should expose port 5000 only inside container,#11ldelaprade wants to merge 1 commit intoibnesayeed:step4from
ldelaprade wants to merge 1 commit intoibnesayeed:step4from
Conversation
hence replacing 'ports' with 'expose' in docker-compose.yml
Owner
|
Thanks for the PR and your thoughts. However, this was an intentional one to allow the API service be exposed publicly the very same way the PHP application is, so that someone who wants to write their own application, they can use the API endpoint instead. While making this change will not necessarily make much difference in the lesson, but it will not bring anything new to the table either. So, it will be an extra work of changing the lesson and getting that reviewed, merged, and deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hence replacing 'ports' with 'expose' in docker-compose.yml.
This would imply a small change in
play-with-docker.github.io/_posts/2018-09-22-microservice-orchestration.markdown
as well to explain the nuance.
So this should be replace as well:
with something like
The PHP web server will access the API which is no longer exposed outside the container.