Add check for OPENJDK_TARGET_CPU_BITS back into configure #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sharon Wang <[email protected]>
keithc-ca
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
When we address ibmruntimes/openj9-openjdk-jdk11#361 we should add more checking (e.g. mixedrefs should not be accepted for (supported) 32-bit targets).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the changes from #458, a check for
"x$OPENJDK_TARGET_CPU_BITS" = x32was mistakenly removed. This resulted in the build getting generated in thecompressedrefsdirectory, instead of thedefaultdirectory, causing the tests in eclipse-openj9/openj9#11187 to fail. Adding this check back in should fix eclipse-openj9/openj9#11187.