Improve support for builds with multiple configurations #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2020
|
jenkins compile aix,osx,win,plinux jdknext |
|
The osx build hung for no obvious reason. https://ci.eclipse.org/openj9/job/Build_JDKnext_x86-64_mac_Personal/45 |
|
jenkins compile osx jdknext |
|
The second one found some diagnostic files |
|
Jenkins compile osx jdknext depends eclipse-omr/omr#5668 |
I don't think those are from the same build. If you look through the log at the corresponding time (2020-11-12T03:04:25) you won't find any messages that should accompany creation of those files. On the other hand, this can't be good (I believe this is the bootjdk talking): |
|
The build is hung again. I didn't stop it. |
|
Given the builds last night were all fine, and osx is failing to compile with this change for jdk11 and jdk15, plus the hangs for jdk16, I'd say this change is problematic for osx. |
Agreed, although it's not immediately clear why only OSX has trouble with this. |
keithc-ca
changed the title
* define J9JCL_SOURCES_DIR & J9JCL_SOURCES_DONEFILE in custom-spec.gmk and use as appropriate * move j9jcl preprocessing to a separate makefile * remove redundant definition of FixPath * remove unused macro OPENJ9_BIN_OR_LIB_DIR Signed-off-by: Keith W. Campbell <[email protected]>
keithc-ca
force-pushed
the
multi_config
branch
from
ee15e75 to
2a8e8a4
Compare
|
As I explored a fix for this, I encountered the symptoms on Linux previously only seen on OSX. The updated code has been seen to work on Linux and OSX. |
|
Jenkins compile aix,osx,plinux,win jdknext |
keithc-ca
changed the title
pshipton
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module-deps.gmkis based on the right set of modulesThe OpenJDK build system supports multiple configurations.
One example use might be building both with UMA and with cmake (while cmake development is ongoing):
Or you might be working on code sensitive to how references are represented [1]:
With multiple configurations, you can say
make CONF= reconfigureormake CONF= clean, butmake CONF= imageswould fail. You could say (for the first example):but that is somewhat tedious, and gets worse as the number of configuration grows. With these changes the shorter
make CONF= imagescommand will work.[1] see ibmruntimes/openj9-openjdk-jdk11#359