Adding support for Apple Silicon #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndrejPer The code looks good, thanks! I would like to check with you that the performance with mps is good, I have seen issues with transformers and mps. |
|
@ajjimeno The code can run, the training is going. It is quite slow on M3 Pro, the first 10 iterations need around 200-250h. Haven't finished that part, so cannot say if it is completely okay, but for now it is training at least. |
|
Thanks @AndrejPer!! Let's keep it as a PR for now. I have seen speed
issues with M2 chips.
…On Mon, Jun 17, 2024 at 12:23 AM AndrejPer ***@***.***> wrote:
@ajjimeno <https://github.com/ajjimeno> The code can run, the training is
going. It is quite slow on M3 Pro, the first 10 iterations need around
200-250h. Haven't finished that part, so cannot say if it is completely
okay, but for now it is training at least.
—
Reply to this email directly, view it on GitHub
<#14 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6BZDJ3THRZCPS64GL6IUTZH2FGXAVCNFSM6AAAAABJD6NRMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZSGQ4DONJSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the two files needed for decoder training, added the option of setting the device to 'mps' besides 'coda' and 'cpu'.