IBX-10648: flatpicrk has default select on safari #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
GrabowskiM,
RopRaptor,
albozek,
alekmick,
dew326 and
tischsoic
and removed request for
a team
OstafinL
force-pushed
the
IBX-10648-flatpicrk-has-default-select-on-safari
branch
from
d41aad8 to
e4a9df8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The select element referenced in the ticket is a native HTML select, which does not support styling with
::afteror::beforepseudo-elements.Therefore, creating a custom arrow using these CSS features is not possible.Using an SVG from our icon library (admin-ui) was also not an option because arrow form our icons library is too heavy for this context.
To achieve a lightweight, visually appropriate arrow, I used a custom inline SVG as a background image. This approach ensures cross-browser compatibility (including Safari) and allows for precise control over the arrow’s appearance without relying on pseudo-elements or external assets.
Safari:
For QA:
Documentation: