Skip to content

IBX-9519: [Behat] Added Behat content tree coverage #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: 4.6
Choose a base branch
from
Open

IBX-9519: [Behat] Added Behat content tree coverage #1685

wants to merge 13 commits into from

Conversation

juskora
Copy link
Contributor

@juskora juskora commented Aug 19, 2025 •
edited
Loading

🎫 Issue IBX-9519

Related PRs:

Description:

This test suite covers the basic tests for the content tree component:

  • check if the header is loaded
  • check if the item is created in the content tree and displayed
  • check if the item is created under specific location in the content tree and displayed
    Plans for the next iteration (to be discussed):
  • extend with test coverage for collapsing content tree elements
  • extend with test coverage for selecting all elements
  • extend with test coverage for deselecting all elements.

For QA:

Documentation:

This was referenced Aug 19, 2025
Closed
Open
@juskora juskora force-pushed the IBX-9519-behat-contenttree branch from 9c21aa2 to f7b174b Compare August 20, 2025 13:20
@juskora juskora force-pushed the IBX-9519-behat-contenttree branch from fb6fe2a to cb9354e Compare August 21, 2025 12:44
@juskora juskora force-pushed the IBX-9519-behat-contenttree branch from 578649c to baa9975 Compare September 4, 2025 09:21
@juskora juskora marked this pull request as ready for review September 4, 2025 10:41
@juskora juskora requested a review from a team September 4, 2025 10:41
@ezrobot ezrobot requested review from KamilSznajdrowicz, barbaragr, katarzynazawada, micszo, pawlakadrian and tomaszszopinski and removed request for a team September 4, 2025 10:41
katarzynazawada
katarzynazawada requested changes Sep 4, 2025
View reviewed changes
features/standard/ContentTree.feature Outdated
| Article2 | art2 | root | eng-GB |
| Article3 | art3 | root | eng-GB |
And I am logged as admin
And I'm on Content view Page for "root/art1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add here a dedicated step to verify items on the content tree?
And I'm on Content view Page for "root/art1" does not verify tree (only main container, breadcrumbs, content name and content type). We need something similar to https://github.com/ibexa/taxonomy/blob/5570a47c15d685381ca6603e27dba6e0a60800d1/features/Taxonomy.feature#L40

features/standard/ContentTree.feature Outdated
| Short title | arttest |
| Intro | TestArticleIntro |
And I perform the "Publish" action
And I should be on Content view Page for "root/art1/arttest" No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verifying items on the content tree also should be added here.

pawlakadrian
pawlakadrian requested changes Sep 5, 2025
View reviewed changes
tomaszszopinski
tomaszszopinski reviewed Sep 10, 2025
View reviewed changes
@juskora juskora force-pushed the IBX-9519-behat-contenttree branch 2 times, most recently from b63fbe9 to c972535 Compare October 6, 2025 12:13
katarzynazawada
katarzynazawada requested changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve issues reported by phpstan and code style check.
Can you run one regression build for the OSS and one for one of the higher editions to make sure the tests are working correctly? (Content tree differs on OSS edition)

src/lib/Behat/BrowserContext/ContentTreeContext.php
/**
* @Given I wait :number seconds
*/
public function iWait(string $number): void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unused, please delete it if so.

src/lib/Behat/Component/ContentTree.php
Comment on lines +38 to +40
new VisibleCSSLocator('treeItem', '.c-tb-list-item-single__label'),
new VisibleCSSLocator('treeElement', '.ibexa-content-tree-container__root .c-tb-list-item-single__element'),
new VisibleCSSLocator('search', '.c-tb-search .ibexa-input'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unused, please delete it if so.

@juskora juskora force-pushed the IBX-9519-behat-contenttree branch from 8e032a9 to 2836713 Compare October 10, 2025 10:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski left review comments

@pawlakadrian pawlakadrian pawlakadrian requested changes

@katarzynazawada katarzynazawada katarzynazawada requested changes

@micszo micszo Awaiting requested review from micszo

@barbaragr barbaragr Awaiting requested review from barbaragr

@KamilSznajdrowicz KamilSznajdrowicz Awaiting requested review from KamilSznajdrowicz

Assignees

@mikadamczyk mikadamczyk

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels

Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@juskora @pawlakadrian @katarzynazawada @tomaszszopinski @mikadamczyk @ciastektk @dew326 @ViniTou