Improvement of Gnome Extension Detection Logic #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iberianpig
force-pushed
the
improve-gnome-extension-matcher
branch
from
eba4118 to
f7d1a23
Compare
- Added `enabled?` method to check if the Gnome Shell extension is enabled. - Improved `backend_klass` method to log a warning if the Gnome extension is not enabled. - Updated the installer path handling for better clarity and maintainability. - Added RSpec tests for the new `enabled?` method, covering scenarios for when the extension is enabled and when it is not. - Enhanced existing tests for install and uninstall methods to ensure they correctly reflect the extension management logic. ref: iberianpig/fusuma#332 closes: iberianpig/fusuma#323
iberianpig
force-pushed
the
improve-gnome-extension-matcher
branch
from
f7d1a23 to
63c463e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: iberianpig/fusuma#323
ref: iberianpig/fusuma#332