Repository navigation
Drop the duplicate month title from the sidebar mini month - #15
Open
piotrkowski wants to merge 1 commit into
Open
piotrkowski wants to merge 1 commit into
piotrkowski wants to merge 1 commit into
Conversation
`month_thumbnail` put a month-name heading on top of its day grid. The year view wants that, but the sidebar wraps the same thumbnail under its own "October 2026" header with the arrows, so the sidebar named the month twice. The heading moves into the year view's loop and the thumbnail is the day grid alone. The year view is laid out as before: the cell spaces the heading from the grid exactly as the thumbnail's column did.
piotrkowski
force-pushed
the
fix/mini-month-duplicate-title
branch
from
October 11, 2026 19:01
8d519a0 to
47963eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
month_thumbnailadds its own month-name heading. That works in the year view, but the sidebar mini month already has a "%B %Y" header with the nav arrows, so the sidebar ends up showing the month twice.This moves the heading into the year view's loop.
month_thumbnailnow returns only the day grid. The year view looks the same as before.Before / after:
Checked with the four CI gates and
cargo test gui_leaks -- --ignored.This and #19 both touch the year view's month heading, so whichever lands second needs a rebase. I'll do it.