Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Javascript Examples Support #5722

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

RavenColEvol
Copy link
Contributor

Description
This PR fixes the concern of having both TS and JS version of examples.
This PR uses tsc to create JS examples. This PR required changes in structure of examples folder and added few utility files like tsconfig.example.json.

Issue
Fixes: #3895

Example
Screenshot 2024-09-18 at 12 13 16 AM

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 1b0b3fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylans dylans merged commit 01dc30b into ianstormtaylor:main Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Documentation should have a user option to display either TypeScript or JavaScript
2 participants