Skip to content

fix: fix startOf + add chain bug in timezone plugin #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eunjios wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: fix startOf + add chain bug in timezone plugin #2895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4f5276
fix: fix startOf + add chain bug in timezone plugin
eunjios Jun 23, 2025
370bb6e
Merge branch 'dev' into dev
iamkun Aug 28, 2025
847da4d
Merge branch 'dev' into dev
iamkun Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/plugin/timezone/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,10 @@ export default (o, c, d) => {
return oldStartOf.call(this, units, startOf)
}

const withoutTz = d(this.format('YYYY-MM-DD HH:mm:ss:SSS'), { locale: this.$L })
const timezone = this.$x.$timezone
const withoutTz = this.clone().$set('$x', {})
const startOfWithoutTz = oldStartOf.call(withoutTz, units, startOf)
return startOfWithoutTz.tz(this.$x.$timezone, true)
return startOfWithoutTz.tz(timezone, true)
}

d.tz = function (input, arg1, arg2) {
Expand Down
15 changes: 15 additions & 0 deletions test/plugin/timezone.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,3 +352,18 @@ describe('UTC timezone', () => {
expect(dayjs2.format()).toBe(moment2.format())
})
})

describe('add after startOf', () => {
it('corrects startOf month in UTC', () => {
const originalDay = dayjs.tz('2025-01-31', 'etc/UTC')
const startOfDay = originalDay.startOf('month')
expect(startOfDay.format('YYYY-MM-DD')).toEqual('2025-01-01')
})

it('corrects startOf and add in UTC', () => {
const originalDay = dayjs.tz('2025-01-31', 'etc/UTC')
const startOfDay = originalDay.startOf('month')
const addedDay = startOfDay.add(3, 'month')
expect(addedDay.format('YYYY-MM-DD')).toEqual('2025-04-01')
})
})