Fix deprecated now #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2015 13:20
The previously widely used now/0 function has been deprecated in favor of different functions for specific tasks. These are things like creating monotonically ordered integers, getting timestamps, performing diffs on timestamps, etc. Reference page for deprecation purpose: http://www.erlang.org/doc/apps/erts/time_correction.html Bump version to 3.3.5
|
Would be nice to continue to be able to support the old versions of OTP (see http://www.erlang.org/doc/apps/erts/time_correction.html#id62299). If you add the required wrapping logic, I promise a very quick turnaround on review and merge. Sorry for a rather significant delay in response. |
|
No problem on the delay. I'll try to put something together soon. |
|
To be honest I'm very new to Erlang and didn't think about this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously widely used now/0 function has
been deprecated in favor of different functions
for specific tasks. These are things like creating
monotonically ordered integers, getting timestamps,
performing diffs on timestamps, etc.
Reference page for deprecation purpose:
http://www.erlang.org/doc/apps/erts/time_correction.html
Bump version to 3.3.5
matching PR for common_lib here