Staging #3
Staging #3
Conversation
- ensure directory is properly linting [Finishes #148533841]
- make sure application runs smoothly [Footer #148533999]
- make sure application runs smoothly [Footer #148533999]
-ensure sequelize is configure properly [Finishes #14854220]
-ensure schemas are linked successfully [Finishes #148544303]
-ensure gulp runs the server without errors [Finishes #149215875]
- make sure user see an exciting gaming screen [Finishes #146622705]
- ensures hound is set up to follow code style guide [Finishes #149221199]
- ensures api endpoints are reachable [Finishes #149221719] '
- ensure user is registered - ensure user data is stored in the database [Finishes #149293369]
-ensures user is logged in ensures a token is given to each logged in user [Finishes #149350019]
- get all users if the user is an admin - return unauthorized access if the user is not an admin [Finishes #14935501]
- ensure users can find a user when logged in [Finishes #149355603]
-ensures user is logged in before updating attributes. ensures user cannot update another user attributes. [Finishes #149356073]
[Finishes #149356281]
- ensure when user search it return the result [Finishes #149357097]
-make sure user can create document and give it an access type [Finishes #149357821]
-user can edit document after creating [Footer #149358075]
- ensure user can find and view document based on public on private access - ensure user can can delete only document associated to the userid [Finishes #149367289]
- ensure user can find and view document based on public on private access - ensure user can can delete only document associated to the userid [Finishes #149367289]
- ensure all document associated to a user Id is retrieved [Footer #149530895]
- ensure user can delete self - ensure admin can delete all users [Finishes #150296222]
- ensure messages are uniform - ensure Read me is descriptive enough [Finishes #150296222]
- ensure document search is better and dynamic - ensure all test are passing after refactoring code [Finishes #150296222]
- ensure document search get documents with trailing space [Finishes #150296222]
- refactor read me to be descriptive [Finishes #150296222]
- refactor test to match [Finishes #150296222]
| /** GET /api/users/id/documents - Find documents of a specific user*/ | ||
| .get(auth.verifyToken, userController.getUserDocuments); | ||
|
|
||
| export default router; |
There was a problem hiding this comment.
'export' is only available in ES6 (use 'esversion: 6').
| @@ -0,0 +1,16 @@ | |||
| import express from 'express'; | |||
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
| /** GET /api/v1/search - search list of documents */ | ||
| .get(auth.verifyToken, searchController.searchDocuments); | ||
|
|
||
| export default router; |
There was a problem hiding this comment.
'export' is only available in ES6 (use 'esversion: 6').
|
Changes Unknown when pulling 58f5831 on staging into ** on master**. |
|
Changes Unknown when pulling 58f5831 on staging into ** on master**. |
- write unit tests - ensure unit tests passes [Finishes #150296222]
- write unit tests - ensure unit tests passes [Finishes #150296222]
| db.User.create(uniqueTest) | ||
| .then() | ||
| .catch((error) => { | ||
| expect(error.errors[0].message).to.equal(`${field} already exist`); |
There was a problem hiding this comment.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
| it(`should fails for existing ${field}`, (done) => { | ||
| db.User.create(uniqueTest) | ||
| .then() | ||
| .catch((error) => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| uniqueFields.forEach((field) => { | ||
| const uniqueTest = Object.assign({}, helper.firstUser); | ||
| uniqueTest[field] = helper.regularUser[field]; | ||
| it(`should fails for existing ${field}`, (done) => { |
There was a problem hiding this comment.
'template literal syntax' is only available in ES6 (use 'esversion: 6').
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
|
|
||
| describe('Unique', () => { | ||
| uniqueFields.forEach((field) => { | ||
| const uniqueTest = Object.assign({}, helper.firstUser); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| }); | ||
|
|
||
| describe('Unique', () => { | ||
| uniqueFields.forEach((field) => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
server/test/models/user.spec.js
Outdated
| ]; | ||
| const uniqueFields = ['userName', 'email']; | ||
| const defaultRoleId = 2; | ||
| let regularUser; |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
server/test/models/user.spec.js
Outdated
| 'password' | ||
| ]; | ||
| const uniqueFields = ['userName', 'email']; | ||
| const defaultRoleId = 2; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
server/test/models/user.spec.js
Outdated
| 'email', | ||
| 'password' | ||
| ]; | ||
| const uniqueFields = ['userName', 'email']; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
server/test/models/user.spec.js
Outdated
| const expect = chai.expect; | ||
|
|
||
| describe('User Model', () => { | ||
| const requiredFields = [ |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
|
||
| const expect = chai.expect; | ||
|
|
||
| describe('User Model', () => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
- ensure document update successfully - ensure document doesn't update data thats not specified for update [Finishes #150296222]
| describe('User Model', () => { | ||
| const uniqueFields = ['userName', 'email']; | ||
| const defaultRoleId = 2; | ||
| let regularUser; |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
|
||
| describe('User Model', () => { | ||
| const uniqueFields = ['userName', 'email']; | ||
| const defaultRoleId = 2; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| import db from '../../models'; | ||
| import helper from '../controllers/mockData'; | ||
|
|
||
| const expect = chai.expect; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: