Skip to content

Reduce nesting - #1749

Merged
aruniverse merged 1 commit into
masterfrom
restructure-packages
Jul 27, 2026
Merged

Reduce nesting#1749
aruniverse merged 1 commit into
masterfrom
restructure-packages

Conversation

@saskliutas

Copy link
Copy Markdown
Member

Reduced unnecessary nesting by removing intermediate itwin folder: packages/itwin/some-package -> packages/some-package

Copilot AI review requested due to automatic review settings July 27, 2026 14:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@saskliutas
saskliutas requested a review from aruniverse July 27, 2026 14:01
@saskliutas

Copy link
Copy Markdown
Member Author

@aruniverse This is repo wide change let me know if you are ok with it and we can by pass approvals to avoid distracting all code owners.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-Widget benchmark

Benchmark suite Current: c0ea49d Previous: 1cf1f1d Deviation Status
models tree creates initial filtered view for 50k target items 815 ms 893 ms -8.73% 〰️
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 106 ms 124 ms -14.52% 〰️
models tree validates categories visibility for imodel with 50k categories 8268 ms 8443 ms -2.07% 〰️
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) 74 ms 87 ms -14.94% 〰️
models tree changing model visibility changes visibility for 50k elements 2546 ms 3297 ms -22.78%
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) 101 ms 0 ms 10100% 🚨
models tree changing category visibility changes visibility for 50k elements 2107 ms 3156 ms -33.24%
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing per-model-category override changes visibility for 50k elements 2210 ms 2997 ms -26.26%
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing element visibility changes only parent nodes visibility with 50k elements 3502 ms 5031 ms -30.39%
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) 67 ms 96 ms -30.21% 〰️
categories tree creates initial filtered view for 50k items 1479 ms 1622 ms -8.82% 〰️
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) 234 ms 484 ms -51.65%
categories tree changing definition container visibility changes visibility for 50k subCategories 2949 ms 2798 ms 5.40% 〰️
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) 53 ms 54 ms -1.85% 〰️
categories tree changing definition container visibility changes visibility for 50k categories 6573 ms 5723 ms 14.85% 🚨
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) 215 ms 122 ms 76.23% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@aruniverse
aruniverse merged commit e4c6fe1 into master Jul 27, 2026
14 of 15 checks passed
@aruniverse
aruniverse deleted the restructure-packages branch July 27, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants