Reduce nesting - #1749
Merged
Merged
Conversation
saskliutas
requested review from
a team,
a-gagnon,
bsy-nicholasw,
eringram,
hl662,
mdastous-bentley and
simnorm
as code owners
July 27, 2026 14:01
Member
Author
|
@aruniverse This is repo wide change let me know if you are ok with it and we can by pass approvals to avoid distracting all code owners. |
There was a problem hiding this comment.
Tree-Widget benchmark
| Benchmark suite | Current: c0ea49d | Previous: 1cf1f1d | Deviation | Status |
|---|---|---|---|---|
models tree creates initial filtered view for 50k target items |
815 ms |
893 ms |
-8.73% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
106 ms |
124 ms |
-14.52% |
〰️ |
models tree validates categories visibility for imodel with 50k categories |
8268 ms |
8443 ms |
-2.07% |
〰️ |
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) |
74 ms |
87 ms |
-14.94% |
〰️ |
models tree changing model visibility changes visibility for 50k elements |
2546 ms |
3297 ms |
-22.78% |
✅ |
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) |
101 ms |
0 ms |
10100% |
🚨 |
models tree changing category visibility changes visibility for 50k elements |
2107 ms |
3156 ms |
-33.24% |
✅ |
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing per-model-category override changes visibility for 50k elements |
2210 ms |
2997 ms |
-26.26% |
✅ |
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing element visibility changes only parent nodes visibility with 50k elements |
3502 ms |
5031 ms |
-30.39% |
✅ |
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) |
67 ms |
96 ms |
-30.21% |
〰️ |
categories tree creates initial filtered view for 50k items |
1479 ms |
1622 ms |
-8.82% |
〰️ |
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) |
234 ms |
484 ms |
-51.65% |
✅ |
categories tree changing definition container visibility changes visibility for 50k subCategories |
2949 ms |
2798 ms |
5.40% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) |
53 ms |
54 ms |
-1.85% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories |
6573 ms |
5723 ms |
14.85% |
🚨 |
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) |
215 ms |
122 ms |
76.23% |
🚨 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced unnecessary nesting by removing intermediate
itwinfolder:packages/itwin/some-package->packages/some-package