[Tree-widget]: move to MUI - #1748
Conversation
| // are not listed in tree-widget's peerDependencies and thus not covered by `collectDepsFromPackage`. | ||
| // Without deduping them, the build resolves them from both this app's and tree-widget's node_modules, | ||
| // producing distinct `RootContext` objects and a "RootContext is undefined" crash at runtime. | ||
| "@stratakit/foundations", |
There was a problem hiding this comment.
@saskliutas not sure how we wanna handle this.
There was a problem hiding this comment.
Why do we need to dedupe @stratakit/foundations? It should not be referenced directly by any of the packages (tree-widget, test-viewer, etc). Only stratakit/mui should be used. Isn't it enough to dedupe that?
There was a problem hiding this comment.
from what i gathered because we use sharedWorkspaceLockfile: false, we get one copy of foundations from tree-widget and one from test-viewer, both coming from their own stratakit/mui, when we dedupe as i understand we get one stratakit/mui with 2 foundations which both create a context. (to be able to dedupe it i need to keep foundations as a dep in test-viewer),
There was a problem hiding this comment.
I guess it's ok to add foundations as dep in test-viewer if that helps.
2 participants
No description provided.