[test-viewer] Bump iTwinUI - #1736
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test-viewer app’s dependency set, primarily bumping @itwin/itwinui-react and re-resolving the workspace dependency graph (lockfile + workspace override configuration) to reflect the new versions.
Changes:
- Bumped
@itwin/itwinui-react^3override from 3.20.1 → 3.21.2 (workspace override). - Updated
apps/test-viewerdependencies to newer@itwin/*versions and regeneratedapps/test-viewer/pnpm-lock.yaml. - Removed the app-local
pnpm.overridesblock inapps/test-viewer/package.jsonin favor of workspace-level overrides.
Reviewed changes
Copilot reviewed 2 out of 38 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates workspace-level override for @itwin/itwinui-react@^3 to 3.21.2. |
| apps/test-viewer/package.json | Bumps many @itwin/* dependencies (including iTwinUI) and removes app-local pnpm overrides. |
| apps/test-viewer/pnpm-lock.yaml | Regenerated lockfile reflecting the new dependency/override resolutions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Tree-Widget benchmark
| Benchmark suite | Current: 1965595 | Previous: b3aed6f | Deviation | Status |
|---|---|---|---|---|
models tree creates initial filtered view for 50k target items |
831 ms |
1149 ms |
-27.68% |
✅ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
101 ms |
145 ms |
-30.34% |
〰️ |
models tree validates categories visibility for imodel with 50k categories |
9059 ms |
11595 ms |
-21.87% |
✅ |
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) |
68 ms |
86 ms |
-20.93% |
〰️ |
models tree changing model visibility changes visibility for 50k elements |
2662 ms |
3551 ms |
-25.04% |
✅ |
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) |
98 ms |
135 ms |
-27.41% |
〰️ |
models tree changing category visibility changes visibility for 50k elements |
2107 ms |
2910 ms |
-27.59% |
✅ |
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing per-model-category override changes visibility for 50k elements |
2198 ms |
3276 ms |
-32.91% |
✅ |
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing element visibility changes only parent nodes visibility with 50k elements |
3376 ms |
4933 ms |
-31.56% |
✅ |
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) |
68 ms |
100 ms |
-32% |
〰️ |
categories tree creates initial filtered view for 50k items |
1261 ms |
1892 ms |
-33.35% |
✅ |
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) |
335 ms |
345 ms |
-2.90% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k subCategories |
2280 ms |
3834 ms |
-40.53% |
✅ |
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) |
36 ms |
55 ms |
-34.55% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories |
4644 ms |
8997 ms |
-48.38% |
✅ |
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) |
89 ms |
186 ms |
-52.15% |
✅ |
This comment was automatically generated by workflow using github-action-benchmark.
grigasp
approved these changes
Jul 10, 2026
aruniverse
approved these changes
Jul 10, 2026
JonasDov
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped iTwinUI to the latest version and updated e2e test screenshots.