[Property grid]: don't hide non empty values - #1724
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1715 where the Property Grid “Hide null values” feature was incorrectly hiding boolean switches (e.g., false) and merged properties by refining the null-value filtering logic and expanding coverage with targeted tests.
Changes:
- Replace the “non-empty” value filter with a “non-null” value filter that uses underlying primitive
valuepresence (instead ofdisplayValuetruthiness). - Update
PropertyGridContentto use the new non-null filterer whenshowNullValuesis disabled. - Add regression tests to ensure
falseboolean primitives and merged primitives are not filtered out.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/itwin/property-grid/src/property-grid-react/components/FilteringPropertyGrid.tsx | Renames/updates the filterer to treat false/merged primitives as non-null. |
| packages/itwin/property-grid/src/property-grid-react/components/PropertyGridContent.tsx | Switches the default “hide nulls” filterer to the new non-null filterer. |
| packages/itwin/property-grid/src/test/components/FilteringPropertyGrid.test.tsx | Adds regression tests for false booleans and merged primitives; updates references to the renamed filterer. |
| change/@itwin-property-grid-react-1715-hide-null-boolean.json | Adds a patch change note for the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grigasp
approved these changes
Jun 17, 2026
saskliutas
reviewed
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/itwin/property-grid/README.md:88
- This README comment still refers to "show/hide null values", but the example now uses
ShowHideEmptyValuesSettingsMenuItem. Updating the wording keeps the documentation consistent with the renamed API.
(props) => <ShowHideEmptyValuesSettingsMenuItem {...props} persist={true} />,
],
// supply an optional custom storage for user preferences, e.g. the show/hide null values used above
preferencesStorage: new IModelAppUserPreferencesStorage("my-favorites-namespace"),
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
saskliutas
approved these changes
Jun 17, 2026
grigasp
reviewed
Jun 18, 2026
…EmptyValuesSetting.tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
JonasDov
enabled auto-merge (squash)
June 18, 2026 08:11
saskliutas
approved these changes
Jun 19, 2026
saskliutas
disabled auto-merge
June 19, 2026 07:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1715