Skip to content

Category count query fix - #1364

Merged
JonasDov merged 9 commits into
masterfrom
JonasD/category-count-ecsql-fix
Jul 3, 2025
Merged

Category count query fix#1364
JonasDov merged 9 commits into
masterfrom
JonasD/category-count-ecsql-fix

Conversation

@JonasDov

@JonasDov JonasDov commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Closes #1360

@JonasDov
JonasDov requested review from a team as code owners July 1, 2025 11:23

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-Widget benchmark

Benchmark suite Current: ef0eb49 Previous: 352f29c Deviation Status
categories tree creates initial filtered view for 50k items 2418.66 ms 2362.32 ms 2.38% 〰️
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) 1651 ms 1608 ms 2.67% 〰️
categories tree changing category visibility changes visibility for 50k subCategories 9413.26 ms 8791.66 ms 7.07% 〰️
categories tree changing category visibility changes visibility for 50k subCategories (P95 of main thread blocks) 3006 ms 2705 ms 11.13% 🚨
categories tree changing definition container visibility changes visibility for 50k categories 7131.15 ms 6116.68 ms 16.59% 🚨
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) 4053 ms 2994 ms 35.37% 🚨
models tree creates initial filtered view for 50k target items 2310.68 ms 2128.03 ms 8.58% 〰️
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 328 ms 71 ms 361.97% 🚨
models tree changing model visibility changes visibility for 50k elements 49741.15 ms 45078.69 ms 10.34% 🚨
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) 277 ms 251 ms 10.36% 〰️
models tree changing category visibility changes visibility for 50k elements 51841.24 ms 44934.69 ms 15.37% 🚨
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) 270 ms 235 ms 14.89% 〰️
models tree changing per-model-category override changes visibility for 50k elements 51527.22 ms 44676.15 ms 15.33% 🚨
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) 267 ms 235 ms 13.62% 〰️
models tree changing element visibility changes only parent nodes visibility with 50k elements 52597.37 ms 45649.8 ms 15.22% 🚨
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) 498 ms 447 ms 11.41% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@JonasDov
JonasDov merged commit 96beca0 into master Jul 3, 2025
14 checks passed
@JonasDov
JonasDov deleted the JonasD/category-count-ecsql-fix branch July 3, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tree widget: sqlite error when hiding selected elements on big imodel

2 participants