CircularProgress & LinearProgress visual styling - #1594
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Can you check if ba6771c is helping? I can't seem to reproduce. Are you by any chance viewing the visual artifacting on a retina display?
There was a problem hiding this comment.
That did not seem to make a difference. I'm on a normal 2560x1440 display.
I saw similar artifacting in your screenshots in the other thread.
There was a problem hiding this comment.
It's probably because of fractional values. Do we have any control over the sizing?
There was a problem hiding this comment.
There was a problem hiding this comment.
Could start working on that PR in parallel. It seems like an important part of fixing the visual styling (which this PR is trying to do).
Edit: What I mean is fixing the default size + thickness, not adding new predetermined sizes.
There was a problem hiding this comment.
I think I'd prefer separate documentation pages per component.
There was a problem hiding this comment.
- Split in cbaf3f2.
- Added color documentation & simplified demos in 8609725.
- Added determinate documentation & extracted demos from Demos for iTwinUI feature parity #1592 in 2d26aec.
I think we'll need to take a closer look at the determinate demos.
There was a problem hiding this comment.
Check for broken links now that /components/progress no longer exists.
And yeah, I don't feel confident in those determinate demos.
There was a problem hiding this comment.
Check for broken links now that
/components/progressno longer exists.
Fixed anchors pointing to old progress docs URL in 1f03f4d.
And yeah, I don't feel confident in those determinate demos.
The things I am uncertain about:
- The extra code to get the progress bar to increase from 0-100% bloats the file while the focus should be on just the component and it's props.
aria-labelledbyis tied only to "Uploading…", does not include the %.- The
CircularProgressrequires an absolute positioned box to get the percentage centered.
There was a problem hiding this comment.
Today we agreed to simplify the determinate examples to show the most basic usage.
There was a problem hiding this comment.
Simplified determinate examples in f8a5294.
There was a problem hiding this comment.
Updated the determinate examples in 7c94fa9 to show the percentage but left out the animation.
Is it caused by this PR? Then we should fix it before merging. Evaluating |
Yes it is, this is from the main branch setting What I think I should do is apply EDIT: colors added in 9cc0a75. |
…ck for track height
…ess-bar2 when variant=buffer height
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
I'm seeing different colors in the two images, possibly because the code was updated as you were capturing the screenshots. Could you re-capture the latest state just to be sure? @angrycat9000 |
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
|








Changes
Progress.mdintoCircularProgress.md&LinearProgress.md.CircularProgress:enableTrackSlotdefaults to true.LinearProgress:variantis set to"buffer"or"determinate".CircularProgressDeploy preview 👀CircularProgressdocumentation 📚LinearProgressDeploy preview 👀LinearProgressdocumentation 📚CircularProgressCircularProgressCircularProgressforced-colorsLinearProgressLinearProgressLinearProgressforced-colorsTesting
forced-colors.coloroptions.variants.