Merge Reality Data Client in Reality Capture - #309
Open
dbiguenet wants to merge 12 commits into
Open
Conversation
dbiguenet
marked this pull request as ready for review
July 3, 2026 07:36
dbiguenet
requested review from
BeChaRem,
MarcBedard8,
RenaudKeriven,
arianacarnielli,
cnovel,
lr06 and
matmarchand
as code owners
July 3, 2026 07:36
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges Reality Management (reality data) client capabilities into the @itwin/reality-capture TypeScript package by introducing a new service/reality_data module and adding Reality Management endpoints to RealityCaptureService, then updating handlers, examples, and tests to use the unified implementation.
Changes:
- Added Reality Management (reality data) schemas/types and query helpers, and exported them from the package entrypoints.
- Implemented Reality Management API endpoints on
RealityCaptureServiceand refactoredRealityDataHandler+ examples to stop using@itwin/reality-data-client. - Expanded/updated unit tests and bumped the package version (with associated repo docs/lockfile updates).
Reviewed changes
Copilot reviewed 21 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| typescript/packages/reality-capture/src/tests/specifications/test_production.test.ts | Removes unused imports after API consolidation. |
| typescript/packages/reality-capture/src/tests/service/service.test.ts | Adds/updates service API call tests, including Reality Management endpoints. |
| typescript/packages/reality-capture/src/tests/service/response.test.ts | Updates assertions around Response null/boolean values. |
| typescript/packages/reality-capture/src/tests/service/reality_data.test.ts | New dedicated schema + Reality Management service tests. |
| typescript/packages/reality-capture/src/tests/service/job.test.ts | Cleans up unused schema imports/helpers in job tests. |
| typescript/packages/reality-capture/src/tests/service/bucket.test.ts | Switches shared URL/container schemas to come from reality_data. |
| typescript/packages/reality-capture/src/service/service.ts | Adds Reality Management URL builder and reality data CRUD/access/association methods. |
| typescript/packages/reality-capture/src/service/reality_data.ts | New Reality Management schemas/types/enums + filter-to-params helper. |
| typescript/packages/reality-capture/src/service/job.ts | Repoints URL schema import and enables ImportPointCloud job union member. |
| typescript/packages/reality-capture/src/service/data_handler.ts | Replaces @itwin/reality-data-client usage with RealityCaptureService endpoints. |
| typescript/packages/reality-capture/src/service/bucket.ts | Removes duplicated URL/container schemas and reuses reality_data schemas. |
| typescript/packages/reality-capture/src/index.web.ts | Exposes service/reality_data from the web entrypoint. |
| typescript/packages/reality-capture/src/index.node.ts | Exposes service/reality_data from the node entrypoint. |
| typescript/packages/reality-capture/README.md | Adds Reality Management API link to package docs. |
| typescript/packages/reality-capture/pnpm-lock.yaml | Removes @itwin/reality-data-client dependency + lockfile churn. |
| typescript/packages/reality-capture/package.json | Major version bump to 2.0.0 and removes @itwin/reality-data-client dependency. |
| typescript/packages/reality-capture/CHANGELOG.md | Adds changelog file content for prior releases. |
| typescript/packages/reality-capture/CHANGELOG.json | Adds changelog JSON entries for prior releases. |
| typescript/examples/src/example_upload_reality_data.ts | Migrates upload example to use RealityCaptureService.createRealityData. |
| typescript/examples/src/example_modeling.ts | Migrates modeling example to use new reality data create + local file checks. |
| typescript/examples/pnpm-lock.yaml | Updates example lockfile after dependency removals/upgrades. |
| typescript/examples/package.json | Removes @itwin/reality-data-client from examples dependencies. |
| README.md | Removes standalone Reality Management client package link. |
| .gitignore | Ignores *.tsbuildinfo. |
| .github/workflows/typescript-ci.yaml | Workflow formatting/indentation updates. |
Files not reviewed (2)
- typescript/examples/pnpm-lock.yaml: Generated file
- typescript/packages/reality-capture/pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
@dbiguenet We are creating a second copy of reality data client, are we planning to delete |
cnovel
approved these changes
Jul 6, 2026
# Conflicts: # typescript/packages/reality-capture/package.json # typescript/packages/reality-capture/src/service/job.ts # typescript/packages/reality-capture/src/tests/service/service.test.ts # typescript/packages/reality-capture/src/tests/specifications/test_production.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.