-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/analyse v2 #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/analyse v2 #306
Changes from 24 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
07b0fe1
Adding O2D training specification (#112)
lioum 7649d4b
Add training S3D specification (#139)
lioum ecd12ef
Add support for Computing Buckets (#143)
cnovel 3f2173c
Correct Training specifications
cnovel 3d00992
Better description
cnovel 5687a0c
Add alias for version_name field of TrainingS3DSpecifications (#247)
lioum b276e3c
Implemented detector handler
lioum 729d855
Fixed tests
lioum 9fbb701
Updated TrainingS3D example
lioum 501ce9f
Remove CRS outputs and segmented as in S3D Specifications (#289)
EHS-BENTLEY-SYSTEMS 226a924
Added PointTransformerV3 to S3D Training models
pierre-seguin-bentley 819fbbd
Accidentaly removed a line in last commit
pierre-seguin-bentley 93ad67f
Merge branch 'feature/2.3.0' into feature/AnalyseV2
pierre-seguin-bentley 95dfbc4
Tmp/ehs/update cd (#299)
EHS-BENTLEY-SYSTEMS 27a25de
Updated training specs for release
pierre-seguin-bentley adc09fb
Updated training specs python examples
pierre-seguin-bentley 52caf91
Updated training specs examples again
pierre-seguin-bentley 0dd5b4b
Fixed bad named / alias for samplingResolution option of CD
pierre-seguin-bentley 8c5cad2
CD and Clearance parameters fixes
RenaudKeriven 5fe0d24
Oops
RenaudKeriven ddc5c4f
Analysis job specifs
RenaudKeriven d464d72
CD locations
RenaudKeriven c5842ef
CD fix
RenaudKeriven f0e3b95
Merge main in feature/AnalysisV2 and fix conflicts
dbiguenet bbc2d24
Potential fix for pull request finding
dbiguenet 6e501df
Potential fix for pull request finding
dbiguenet 3b6d16a
Remove orig files
dbiguenet 9548392
Merge remote-tracking branch 'origin/feature/AnalyseV2' into AnalysisV2
dbiguenet 95598e9
Fix data_handler.py
dbiguenet 688011d
Potential fix for pull request finding
dbiguenet 11497c0
Remove crs from s3d doc
dbiguenet 102f631
Fix data_handler.py
dbiguenet 41f11ad
Merge remote-tracking branch 'origin/feature/AnalyseV2' into AnalysisV2
dbiguenet c97590e
Fix change detection tests
dbiguenet aceb2fe
Fix change detection tests
dbiguenet ba16bdc
Fix typescript change detection example
dbiguenet c0c9842
Fix misspelled TrainingS3D in job.ts
dbiguenet 23ba1ee
Potential fix for pull request finding
dbiguenet 168389f
Potential fix for pull request finding
dbiguenet b7edf70
Potential fix for pull request finding
dbiguenet 9fe5409
Fix preset in change detection. Will be released later.
dbiguenet 12f1278
Merge remote-tracking branch 'origin/feature/AnalyseV2' into AnalysisV2
dbiguenet 50b704f
Potential fix for pull request finding
dbiguenet 358b075
Fix typescript change detection
dbiguenet 379cb39
Potential fix for pull request finding
dbiguenet 2a80cf5
Fix python job.py tests
dbiguenet f99869a
Merge remote-tracking branch 'origin/feature/AnalyseV2' into AnalysisV2
dbiguenet 294b501
Remove clearance
dbiguenet 9a37d86
Try to fix tests error
dbiguenet eb2ec81
Fix another issue in change detection tests
dbiguenet df4d187
Removed detector data handler (#315)
lioum 0bdf6df
Remove unused properties
cnovel a1e7d97
Fix doc
cnovel 01ad1ca
Remove bad option from TS
cnovel 5d47b2e
Enable preset in CD
cnovel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 3 additions & 3 deletions
6
python_sdk/docs/specifications/examples/cd_specs_detect_changes_meshes.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import reality_capture.specifications.change_detection as change_detection | ||
|
|
||
| cd_inputs = change_detection.ChangeDetectionInputs(model3dA="279db84b-090f-4922-b9a5-7a4fd0a71fcd", | ||
| model3dB="40af080d-7ata-48c8-974c-610820fe90f2") | ||
| cd_outputs = [change_detection.ChangeDetectionOutputsCreate.OBJECTS3D] | ||
| cd_inputs = change_detection.ChangeDetectionInputs(model3DA="279db84b-090f-4922-b9a5-7a4fd0a71fcd", | ||
| model3DB="40af080d-7ata-48c8-974c-610820fe90f2") | ||
| cd_outputs = [change_detection.ChangeDetectionOutputsCreate.LOCATIONS3D_AS_GEOJSON] | ||
| cd_options = change_detection.ChangeDetectionOptions() | ||
|
Copilot marked this conversation as resolved.
|
||
| cds = change_detection.ChangeDetectionSpecificationsCreate(inputs=cd_inputs, outputs=cd_outputs, options=cd_options) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import reality_capture.specifications.clearance as clearance | ||
|
|
||
| clearance_inputs = clearance.ClearanceInputs(model3d="084985b0-71b5-4b02-a788-db261dd0730c", | ||
| clearance_inputs = clearance.ClearanceInputs(model3D="084985b0-71b5-4b02-a788-db261dd0730c", | ||
| clearanceFootprint="635f801b-82cc-4477-8d59-f01eb2fea1d9") | ||
| clearance_outputs = [clearance.ClearanceOutputsCreate.OVF_AREAS, clearance.ClearanceOutputsCreate.OVF_LINES] | ||
| clearance_specs = clearance.ClearanceSpecificationsCreate(inputs=clearance_inputs, outputs=clearance_outputs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
python_sdk/docs/specifications/examples/training_s3d_default.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import reality_capture.specifications.training as training | ||
|
|
||
| training_s3d_inputs = training.TrainingS3DInputs( | ||
| segmentations3D=["401975b7-0c0a-4498-5896-84987921f4bb"], | ||
| detectorName="example-detector", | ||
| ) | ||
|
|
||
| training_s3d_outputs = [ | ||
| training.TrainingS3DOutputsCreate.DETECTOR, | ||
| ] | ||
|
|
||
| training_s3ds = training.TrainingS3DSpecificationsCreate( | ||
| inputs=training_s3d_inputs, outputs=training_s3d_outputs | ||
| ) |
22 changes: 22 additions & 0 deletions
22
python_sdk/docs/specifications/examples/training_s3d_options.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import reality_capture.specifications.training as training | ||
|
|
||
| training_s3d_inputs = training.TrainingS3DInputs( | ||
| segmentations3D=["401975b7-0c0a-4498-5896-84987921f4bb"], | ||
| detectorName="example-detector", | ||
| ) | ||
|
|
||
| training_s3d_outputs = [ | ||
| training.TrainingS3DOutputsCreate.DETECTOR, | ||
| ] | ||
|
|
||
| training_s3d_options = training.TrainingS3DOptions( | ||
| epochs=2, | ||
| spacing=0.2, | ||
| model=training.Segmentation3DTrainingModel.SPLATNET, | ||
| features=[training.PointCloudFeature.RGB, training.PointCloudFeature.INTENSITY], | ||
| versionNumber="1.0", | ||
| ) | ||
|
|
||
| training_s3ds = training.TrainingS3DSpecificationsCreate( | ||
| inputs=training_s3d_inputs, outputs=training_s3d_outputs, options=training_s3d_options | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| ============ | ||
| Training S3D | ||
| ============ | ||
|
|
||
| The *Training S3D* job uses a ContextScene containing annotated pointclouds to train a new S3D detector. | ||
|
|
||
| .. contents:: Quick access | ||
| :local: | ||
| :depth: 2 | ||
|
|
||
| Purpose | ||
| ======= | ||
|
|
||
| This job has the following purposes: | ||
|
|
||
|
|
||
| .. list-table:: | ||
| :widths: auto | ||
| :header-rows: 1 | ||
|
|
||
| * - Purpose | ||
| - Inputs | ||
| - Possible outputs | ||
| - Useful options | ||
| * - Train new detector on a dataset (ContextScene) | ||
| - | *scene*, | ||
| - | *detector*, | ||
| - | *epochs* | ||
| | *max_train_split* | ||
|
dbiguenet marked this conversation as resolved.
Outdated
|
||
|
|
||
|
Copilot marked this conversation as resolved.
Outdated
|
||
|
|
||
| Examples | ||
| ======== | ||
|
|
||
| In this example, we will create a specification for submitting a Training S3D job to produce a new S3D detector from a ContextScene. | ||
|
|
||
| .. literalinclude:: examples/training_s3d_new_default.py | ||
| :language: Python | ||
|
Copilot marked this conversation as resolved.
dbiguenet marked this conversation as resolved.
|
||
|
|
||
| Classes | ||
| ======= | ||
|
|
||
| .. currentmodule:: reality_capture.specifications.training | ||
|
|
||
| .. autopydantic_model:: TrainingS3DSpecificationsCreate | ||
|
|
||
| .. autoclass:: TrainingS3DOutputsCreate | ||
| :show-inheritance: | ||
| :members: | ||
| :undoc-members: | ||
|
|
||
| .. autopydantic_model:: TrainingS3DSpecifications | ||
|
|
||
| .. autopydantic_model:: TrainingS3DInputs | ||
| :model-show-json: False | ||
|
|
||
| .. autopydantic_model:: TrainingS3DOutputs | ||
| :model-show-json: False | ||
|
|
||
| .. autopydantic_model:: TrainingS3DOptions | ||
| :model-show-json: False | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.