Update codeowners - #305
Conversation
Mathieu, Rémi and Marc are now just mentionned whenever we change reality-data-client
|
@copilot Check if the new workflow works fine, without holes in its logic. |
I reviewed and hardened the workflow logic in commit Key fixes:
I also ran validation checks (Code Review + CodeQL) after the updates. |
There was a problem hiding this comment.
🟡 Not ready to approve
The new workflow has a confirmed async bug (missing await) and the CODEOWNERS/global ownership change appears to go beyond the PR description and needs confirmation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds an automation workflow to notify specific maintainers when typescript/packages/reality-data-client/ changes, and updates CODEOWNERS to reflect new ownership for that path (with maintainers now notified via workflow rather than code ownership).
Changes:
- Add a GitHub Actions workflow that comments on PRs touching
typescript/packages/reality-data-client/**to mention the maintainers. - Update
.github/CODEOWNERSentries, including changing the owners fortypescript/packages/reality-data-client/and adjusting the global*rule.
File summaries
| File | Description |
|---|---|
.github/workflows/mention-reality-data-client-changes.yml |
New workflow to comment and mention maintainers when reality-data-client files are changed. |
.github/CODEOWNERS |
Updates ownership rules, including the reality-data-client path and the global catch-all rule. |
Review details
Suppressed comments (2)
.github/workflows/mention-reality-data-client-changes.yml:65
github.rest.issues.createComment(...)returns a promise; withoutawait, the script can finish before the API call completes, causing the mention comment to be skipped intermittently.
github.rest.issues.createComment({
.github/workflows/mention-reality-data-client-changes.yml:37
- This step says it gets “all comments on the PR”, but
issues.listCommentsonly returns PR issue comments (not review comments/reviews). If a maintainer is already mentioned in a review thread, this workflow will still ping them again.
// Get all comments on the PR
const comments = await github.paginate(github.rest.issues.listComments, {
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number
});
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Mathieu, Rémi and Marc are now just mentionned whenever we change reality-data-client