Add Conversion jobs - #277
Open
cnovel wants to merge 21 commits into
Open
Conversation
# Conflicts: # python_sdk/docs/specifications/index.rst # python_sdk/src/reality_capture/service/job.py # python_sdk/src/reality_capture/service/service.py # python_sdk/tests/test_job.py # python_sdk/tests/test_job_validator.py # python_sdk/tests/test_service_base.py # typescript/packages/reality-capture/src/service/job.ts
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for Reality Conversion jobs across the TypeScript and Python SDKs by introducing new job specification models, wiring them into job/service routing, and documenting/testing the new capabilities.
Changes:
- Added new Conversion job specification schemas/models (PointCloudConversion, PointCloudOptimization, MeshSampling, VectorOptimization, TileMapOptimization, ContextSceneTiler) in both TS (zod) and Python (pydantic).
- Updated JobType/Service routing and job validation to recognize the new Conversion job types.
- Added Python docs + examples and extended Python tests for conversion service URL handling and job/spec validation.
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| typescript/packages/reality-capture/src/specifications/vector_optimization.ts | Adds Zod schemas/types for vector optimization job specs. |
| typescript/packages/reality-capture/src/specifications/tile_map_optimization.ts | Adds Zod schemas/types for tile map optimization job specs. |
| typescript/packages/reality-capture/src/specifications/point_cloud_optimization.ts | Adds Zod schemas/types for point cloud optimization job specs. |
| typescript/packages/reality-capture/src/specifications/point_cloud_conversion.ts | Adds Zod schemas/types for point cloud conversion job specs. |
| typescript/packages/reality-capture/src/specifications/mesh_sampling.ts | Adds Zod schemas/types for mesh sampling job specs. |
| typescript/packages/reality-capture/src/specifications/cs_tiler.ts | Adds Zod schemas/types for ContextScene tiler job specs. |
| typescript/packages/reality-capture/src/service/job.ts | Wires new conversion specs into JobType, Job schemas, and service selection. |
| typescript/examples/src/example_modeling.ts | Refactors/cleans up modeling example typings and job monitoring code. |
| python_sdk/src/reality_capture/specifications/vector_optimization.py | Adds pydantic models for vector optimization specs/options. |
| python_sdk/src/reality_capture/specifications/tile_map_optimization.py | Adds pydantic models for tile map optimization specs/options. |
| python_sdk/src/reality_capture/specifications/point_cloud_optimization.py | Adds pydantic models for point cloud optimization specs/options. |
| python_sdk/src/reality_capture/specifications/point_cloud_conversion.py | Replaces old commented prototype with actual pydantic conversion spec models. |
| python_sdk/src/reality_capture/specifications/mesh_sampling.py | Adds pydantic models for mesh sampling specs/options. |
| python_sdk/src/reality_capture/specifications/cs_tiler.py | Adds pydantic models for ContextScene tiler specs/options. |
| python_sdk/src/reality_capture/service/service.py | Adds conversion service base URL and routing. |
| python_sdk/src/reality_capture/service/job.py | Adds Conversion job types and spec validation/mapping. |
| python_sdk/tests/test_service_base.py | Extends service tests to include Conversion routing. |
| python_sdk/tests/test_job.py | Enables/updates conversion service mapping tests. |
| python_sdk/tests/test_job_validator.py | Adds validation coverage for the new conversion job specs. |
| python_sdk/docs/specifications/index.rst | Adds Conversion section and links to new spec docs. |
| python_sdk/docs/specifications/vector_optimization.rst | New docs page for vector optimization. |
| python_sdk/docs/specifications/tile_map_optimization.rst | New docs page for tile map optimization. |
| python_sdk/docs/specifications/pc_optimization.rst | New docs page for point cloud optimization. |
| python_sdk/docs/specifications/pc_conversion.rst | New docs page for point cloud conversion. |
| python_sdk/docs/specifications/mesh_sampling.rst | New docs page for mesh sampling. |
| python_sdk/docs/specifications/cs_tiler.rst | New docs page for ContextScene tiler. |
| python_sdk/docs/specifications/examples/vector_optim.py | Adds vector optimization example script. |
| python_sdk/docs/specifications/examples/tm_optimization.py | Adds tile map optimization example script. |
| python_sdk/docs/specifications/examples/pc_optim_specs.py | Adds point cloud optimization example script. |
| python_sdk/docs/specifications/examples/pc_conv_specs.py | Adds point cloud conversion example script. |
| python_sdk/docs/specifications/examples/mesh_sampling_specs.py | Adds mesh sampling example script. |
| python_sdk/docs/specifications/examples/cs_tiler_specs.py | Adds ContextScene tiler example script. |
Comments suppressed due to low confidence (1)
python_sdk/src/reality_capture/service/job.py:181
- Same issue here: a tab character is used for indentation in the
Union[...]list (ClearanceSpecificationsentry). Please replace tabs with spaces for consistent formatting.
TouchUpImportSpecifications, WaterConstraintsSpecifications,
PointCloudConversionSpecifications, PCOptimizationSpecifications,
MeshSamplingSpecifications, TileMapOptimizationSpecifications,
VectorOptimizationSpecifications, ContextSceneTilerSpecifications,
ClearanceSpecifications] = (
Field(description="Specifications aligned with the job type."))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cnovel
marked this pull request as ready for review
June 8, 2026 07:32
dbiguenet
reviewed
Jun 8, 2026
dbiguenet
requested changes
Jun 8, 2026
dbiguenet
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.