[Hierarchies-react]: Tree action base allow optional onClick - #1469
Merged
Conversation
🦋 Changeset detectedLatest commit: 5f814e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the @itwin/presentation-hierarchies-react StrataKit tree action base API to allow consumers to omit an onClick handler when rendering TreeActionBase, and aligns the extracted API report and versioning metadata accordingly.
Changes:
- Made
TreeActionBaseProps.onClickoptional inTreeActionBase’s public props type. - Updated the package API extract report to reflect the signature change.
- Added a patch changeset documenting the consumer-facing change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/hierarchies-react/src/presentation-hierarchies-react/stratakit/TreeAction.tsx | Makes onClick optional on TreeActionBaseProps. |
| packages/hierarchies-react/api/presentation-hierarchies-react-extract.api.md | Updates extracted API to match the optional onClick prop. |
| .changeset/yellow-kings-cut.md | Adds a patch changeset describing the optional onClick change. |
JonasDov
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case
hideis set to true we should not force consumers to pass in an onClick