Fix audit issues - #145
Merged
Merged
Conversation
Add webpack-batteries-included-preprocessor polyfills to integration.cypress.config.ts to restore Node built-ins that were removed in @cypress/webpack-batteries-included-preprocessor@4: crypto, events, https, http, url, util. Also upgrade @cypress/webpack-preprocessor to ^6.0.4 in minio and s3 to match the peer dep requirement of batteries-included@4.
In pnpm's isolated node_modules, the batteries-included preprocessor cannot resolve 'typescript' via require() from within its own package tree. Passing the imported typescript module explicitly to getFullWebpackOptions() ensures TypeScript loader is set up correctly for .ts spec files. Also move typescript to dependencies so it is resolvable when the config is used at runtime.
This reverts commit 72d8718.
This reverts commit a2aacd9.
This reverts commit a6b86ad.
There was a problem hiding this comment.
Pull request overview
This PR addresses dependency audit findings across the monorepo by upgrading several tooling dependencies (Cypress, nyc, eslint-plugin-deprecation, and Cypress webpack preprocessor), adding/adjusting pnpm overrides for vulnerable transitive packages, and updating webpack configs used for frontend integration-test bundling.
Changes:
- Bump Cypress to
^15.15.0and nyc to^18.0.0across multiple packages. - Upgrade
@cypress/webpack-batteries-included-preprocessorto^4.1.1and adjust Cypress config import usage. - Update Rush/pnpm
globalOverridesforfast-xml-parser,serialize-javascript, and adduuid.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/common-config/s3.unit.cypress.config.ts | Updates import style for Cypress webpack preprocessor used in S3 unit Cypress config. |
| utils/common-config/package.json | Upgrades eslint-plugin-deprecation to a newer major to address audit concerns. |
| tests/frontend-storage/package.json | Upgrades Cypress dependency for frontend storage tests. |
| storage/s3/package.json | Upgrades Cypress tooling dependencies (incl. batteries-included preprocessor, Cypress, nyc). |
| storage/oss/webpack.config.js | Adds webpack DefinePlugin configuration for frontend test bundle builds. |
| storage/oss/package.json | Upgrades nyc. |
| storage/minio/webpack.config.js | Adds webpack DefinePlugin configuration for frontend test bundle builds. |
| storage/minio/package.json | Upgrades Cypress tooling dependencies (incl. batteries-included preprocessor, Cypress, nyc). |
| storage/google/webpack.config.js | Adds webpack DefinePlugin configuration for frontend test bundle builds. |
| storage/google/package.json | Upgrades Cypress and nyc. |
| storage/core/package.json | Upgrades Cypress and nyc. |
| storage/azure/webpack.config.js | Adds webpack DefinePlugin configuration for frontend test bundle builds. |
| storage/azure/package.json | Upgrades Cypress and nyc. |
| common/config/rush/pnpm-config.json | Updates/extends pnpm global overrides for audit remediation. |
| cloud-agnostic/core/package.json | Upgrades Cypress and nyc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aerimagne
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.