-
Notifications
You must be signed in to change notification settings - Fork 244
SchemaView performance improvements #9431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rschili
wants to merge
46
commits into
master
Choose a base branch
from
rschili/schema-view-fragment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 38 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
d2fba12
refactor(ecschema-metadata): move SchemaView into src/SchemaView subf…
rschili 38bc119
feat: add schema_view_fragment pragma for incremental schema loading
rschili 5c360a4
feat: implement incremental schema loading with schema_view_fragment …
rschili 016920f
docs: update SchemaView documentation for clarity and consistency
rschili 84f8772
docs: rename SchemaView section to Intro for improved clarity
rschili bf9bacd
docs: update references from PRAGMA schema_token to PRAGMA checksum(s…
rschili 1d668d1
fix: update primitiveType from uint8 to uint16 in SchemaView binary f…
rschili 61ae7d2
test: enhance SchemaViewFragmentLoading tests with native log capturing
rschili 17b73ef
Merge branch 'master' into rschili/schema-view-fragment
rschili 7dcbd6e
Fix documentation for PRAGMA schema_view and schema_view_fragment to …
rschili df29492
Refactor comments in SchemaViewFragmentLoading tests for clarity and …
rschili be62c05
Refactor SchemaView documentation for clarity and conciseness
rschili 9770c9a
Refactor SchemaView documentation for clarity and conciseness
rschili 51b3ac0
Merge branch 'master' into rschili/schema-view-fragment
rschili 33510bc
Refactor schema loading logic in IModelDb to improve promise handling
rschili 4e92bc2
Merge branch 'rschili/schema-view-fragment' of https://github.com/iTw…
rschili dacf252
Refactor SchemaManifest and related components for improved clarity a…
rschili 1b932e0
Enhance IModelDb schema loading logic and add entries getter in Schem…
rschili bb1c7a2
Add internal documentation and improve error handling in SchemaView a…
rschili d988637
Refactor SchemaView fragment loading tests to use StandaloneDb and im…
rschili 898b6fb
Merge branch 'master' into rschili/schema-view-fragment
rschili 057699b
Merge branch 'rschili/schema-view-fragment' of https://github.com/iTw…
rschili 0812a46
feat(schema): Implement SchemaViewManager for improved schema loading…
rschili 1fbeddb
refactor(schema): Update schema view fragment handling to use schema …
rschili 33a681d
Merge remote-tracking branch 'origin/master' into rschili/schema-view…
rschili f31f98b
Merge branch 'master' into rschili/schema-view-fragment
rschili cf327bc
Potential fix for pull request finding
rschili bbef643
Potential fix for pull request finding
rschili 7a24cdf
Merge branch 'master' into rschili/schema-view-fragment
rschili a486862
Refactor schema view cache management in tests to use SchemaViewManager
rschili ca5b8dd
revert generated unit file
rschili 320174d
Add schema filter to SchemaView for core-backend, core-frontend, core…
rschili 368275b
extract-api and fix some broken links
rschili 5886372
Potential fix for pull request finding
rschili 11b79b1
Potential fix for pull request finding
rschili 60c584d
Potential fix for pull request finding
rschili 8d8025f
Merge branch 'master' into rschili/schema-view-fragment
rschili 228c156
Add performance comparison test for SchemaView and improve validation…
rschili d610576
fix linter problem and strip unnecessary details from docs
rschili 9a86cff
Update rschili-schema-view-fragment_2026-07-23-15-54-03.json
rschili 5080323
Update rschili-schema-view-fragment_2026-07-23-15-54-03.json
rschili 6e7e358
Update rschili-schema-view-fragment_2026-07-23-15-54-03.json
rschili 1be1c24
Fix comment based on review nit.
rschili 57deda8
Merge branch 'rschili/schema-view-fragment' of https://github.com/iTw…
rschili 77c8b35
refactor: Improve documentation and comments in SchemaView and relate…
rschili c6b23f5
refactor: Rework some documentation and skip one unnecessary invalida…
rschili File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
common/changes/@itwin/core-backend/rschili-schema-view-fragment_2026-07-23-15-54-03.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/core-backend", | ||
| "comment": "add schema filter to SchemaView", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-backend" | ||
| } |
10 changes: 10 additions & 0 deletions
10
common/changes/@itwin/core-frontend/rschili-schema-view-fragment_2026-07-23-15-54-03.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/core-frontend", | ||
| "comment": "add schema filter to SchemaView", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/core-frontend" | ||
| } |
10 changes: 10 additions & 0 deletions
10
...on/changes/@itwin/ecschema-metadata/rschili-schema-view-fragment_2026-07-23-15-54-03.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@itwin/ecschema-metadata", | ||
| "comment": "add schema fragments feature and abstraction manager layer for schemaview", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@itwin/ecschema-metadata" | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog comments should be user friendly messages with markdown syntax. Should start with uppercase letter, code in backticks, etc. And should be understandable by someone who's only familiar with the public api (at best).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown? I adjusted the message but kept it short. Are you saying this should include detailed examples, too? That seems redundant to NextVersion.md and the documentation that is included.