Add the example code-snippet from itwinjs-core to this repo instead - #228
Open
nick4598 wants to merge 8 commits into
Open
Add the example code-snippet from itwinjs-core to this repo instead#228nick4598 wants to merge 8 commits into
nick4598 wants to merge 8 commits into
Conversation
ben-polinsky
self-requested a review
January 7, 2025 20:57
| }); | ||
| } | ||
|
|
||
| namespace arbitraryEdit { |
Contributor
There was a problem hiding this comment.
Curious as to why this counter is outside of the function, is it expected to be referenced elsewhere?
Contributor
Author
There was a problem hiding this comment.
My guess is its to achieve a static variable, which I suppose aren't supported in javascript (I.e. just writing static in front of a var within a function)
ben-polinsky
reviewed
Dec 3, 2025
Contributor
There was a problem hiding this comment.
On line 74 - that method has moved to transformer, so you need The [IModelCloneContext]($transformer) to get the docs build passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.