Add test for updating an element with multiple external aspects - #57
Open
jackson-at-bentley wants to merge 3 commits into
Open
Add test for updating an element with multiple external aspects#57jackson-at-bentley wants to merge 3 commits into
jackson-at-bentley wants to merge 3 commits into
Conversation
jackson-at-bentley
requested review from
abeesh,
admccarthy1,
akshay-madhukar,
jchick-bentley,
jffmarker and
swwilson-bsi
as code owners
July 26, 2022 23:37
admccarthy1
approved these changes
Sep 7, 2022
jackson-at-bentley
force-pushed
the
external-aspect-update
branch
from
September 7, 2022 22:06
724a4a7 to
0f9bf76
Compare
Contributor
Author
|
Adam do you understand what's going on here? From aspect fundamentals,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to figure out why our call to
updateAspectworks without passing it an ID property. If you look at the source code forEntityPropsit says the ID is mandatory.If anyone knows how this call works please let me know. I assume it's related to an implementation detail of aspects. The aspect API has been confusing me for a while now.