Add coverage width to parametric deck profile - #748
Open
dovydasjaru wants to merge 1 commit into
Open
Conversation
mantvydasdeltuva
left a comment
mantvydasdeltuva
left a comment
Contributor
There was a problem hiding this comment.
Probably not fully changed
| <ECProperty propertyName="Depth" typeName="double" displayLabel="Depth" description="Depth." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="TopFlatWidth" typeName="double" displayLabel="Top Flat Width" description="Width of top flat." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="BottomRibWidth" typeName="double" displayLabel="Bottom Rib Width" description="Width of bottom rib." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="CoverageWidth" typeName="double" displayLabel="Coverage Width" description="Width of coverage." kindOfQuantity="AECU:LENGTH_SHORT" /> |
Contributor
There was a problem hiding this comment.
Shouldn't this be removed/depricated as now ParametricDeckProfile passes down this property? @dovydasjaru
| <ECProperty propertyName="Depth" typeName="double" displayLabel="Depth" description="Depth." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="TopFlatWidth" typeName="double" displayLabel="Top Flat Width" description="Width of top flat." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="RibSpacing" typeName="double" displayLabel="Rib Spacing" description="Spacing between ribs." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="CoverageWidth" typeName="double" displayLabel="Coverage Width" description="Width of coverage." kindOfQuantity="AECU:LENGTH_SHORT" /> |
| <BaseClass>ParametricDeckProfile</BaseClass> | ||
| <ECProperty propertyName="Depth" typeName="double" displayLabel="Depth" description="Depth." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="WaveLength" typeName="double" displayLabel="Wave Length" description="Wave Length." kindOfQuantity="AECU:LENGTH_SHORT" /> | ||
| <ECProperty propertyName="CoverageWidth" typeName="double" displayLabel="Coverage Width" description="Width of coverage." kindOfQuantity="AECU:LENGTH_SHORT" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.