Fix: Favorite icon shifts on hover in OS+ - #187
Merged
Conversation
…inTile and IModelTile
arome
enabled auto-merge (squash)
November 5, 2025 20:25
arome
disabled auto-merge
November 5, 2025 20:37
arome
enabled auto-merge (squash)
November 5, 2025 21:06
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a visual bug where the favorite icon shifts when hovering over iModel and iTwin tiles. The fix changes the display property from block to flex to prevent layout shifts. Additionally, the PR enhances the "Remove from recents" context menu action by moving it to the top of the menu and adding support for a custom icon.
Key Changes:
- Fixed favorite icon hover behavior by changing CSS display property from
blocktoflex - Reordered "Remove from recents" action to appear first in the context menu
- Added optional
removeFromRecentsIconprop to customize the remove action icon
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IModelTile.module.scss | Changed favorite icon display from block to flex to prevent hover shift |
| ITwinTile.module.scss | Applied same display fix for iTwin tiles |
| IModelGrid.tsx | Added removeFromRecentsIcon prop and reordered context menu actions |
| IModelGrid.stories.tsx | Added storybook examples demonstrating custom icon usage |
| omar-fix-favorite-hover_2025-11-05-20-19.json | Added changelog entry for the patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simihartstein
approved these changes
Nov 6, 2025
aruniverse
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gif of the issue being fixed:
Also moved the "Remove from recents" option to the top of the list and provide user the option to add a custom icon before the text.
