Fix initial theme applied to stories in storybook - #182
Merged
Conversation
arome
commented
Oct 16, 2025
Contributor
| Before | After |
|---|---|
![]() |
![]() |
…ling in Storybook
arome
enabled auto-merge (squash)
October 16, 2025 19:31
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the initial theme application in Storybook by replacing a custom dark mode implementation with the official storybook-dark-mode hook. The custom implementation relied on listening to channel events which didn't properly handle initial state, causing stories to render with incorrect themes on first load.
- Replaced custom
useThemehook withuseDarkModefromstorybook-dark-modepackage - Upgraded
@itwin/itwinui-reactto version^3.19.4to support the theme fix - Removed unused React import and channel-based event listener implementation
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apps/storybook/package.json | Updated @itwin/itwinui-react dependency to ^3.19.4 |
| packages/apps/storybook/.storybook/preview.js | Replaced custom theme hook with useDarkMode from storybook-dark-mode and removed unused imports |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aruniverse
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

