Skip to content

Bug: Do not increment page when fetching is not done #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansrajkvb merged 10 commits into from
Oct 10, 2025
Merged

Bug: Do not increment page when fetching is not done #181

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a45be41
Updated itwinui to 3.19.4, stopped propagation
hansrajkvb Sep 22, 2025
c886a0d
Added guard for $top to not be negative, changed test to reflect chan…
hansrajkvb Sep 23, 2025
dc760fa
change file
hansrajkvb Sep 23, 2025
3074097
Stop further fetch when failed
hansrajkvb Sep 26, 2025
c1ed5a5
Apply suggestion from @alexdunae
hansrajkvb Sep 26, 2025
b53c70e
Merge branch 'main' into hans/fix_imodel_fetch_when_not_yet_loaded
hansrajkvb Oct 10, 2025
9234fa3
Fixed bug where fetching never happens when access token has not yet …
hansrajkvb Oct 10, 2025
9f8330d
Delete common/changes/@itwin/imodel-browser-react/hans-stop_propagati…
hansrajkvb Oct 10, 2025
6a9891f
Added test
hansrajkvb Oct 10, 2025
d9c53ed
Merge branch 'hans/fix_imodel_fetch_when_not_yet_loaded' of https://g…
hansrajkvb Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...twin/imodel-browser-react/hans-fix_imodel_fetch_when_not_yet_loaded_2025-10-10-02-55.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/imodel-browser-react",
"comment": "Fixed bug where fetching never happens when access token has not yet loaded",
"type": "patch"
}
],
"packageName": "@itwin/imodel-browser-react"
}
8 changes: 7 additions & 1 deletion packages/modules/imodel-browser/src/containers/iModelGrid/useIModelData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,13 @@ export const useIModelData = ({
}, []);

const fetchMore = React.useCallback(() => {
if (needsUpdate || status === DataStatus.Fetching || !morePagesAvailable) {
if (
needsUpdate ||
status === DataStatus.Fetching ||
Comment thread
alexdunae marked this conversation as resolved.
status === DataStatus.TokenRequired ||
status === DataStatus.ContextRequired ||
!morePagesAvailable
) {
return;
}
setPage(page + 1);
Expand Down