Skip to content

Fix: Cursor pointer on clickable row for latest iTwinUI #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arome merged 2 commits into from
Oct 9, 2025
Merged

Fix: Cursor pointer on clickable row for latest iTwinUI #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f906cc
Feat: Add cursor pointer style for row elements in ITwinGrid and IMod…
arome Oct 9, 2025
49b92ff
Feat: Add cursor pointer style for clickable rows in @itwin/imodel-br…
arome Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...n/changes/@itwin/imodel-browser-react/omar-fix-cursor-row-clickable_2025-10-09-13-29.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/imodel-browser-react",
"comment": "Fix: Cursor pointer on clickable rows in table",
"type": "patch"
}
],
"packageName": "@itwin/imodel-browser-react"
}
2 changes: 1 addition & 1 deletion packages/modules/imodel-browser/src/containers/ITwinGrid/ITwinGrid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
}

.row-cursor {
div[role="rowgroup"] div[role="row"] {
div[role="row"] {
cursor: pointer;
}
}
2 changes: 1 addition & 1 deletion packages/modules/imodel-browser/src/containers/ITwinGrid/ITwinGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ export const ITwinGrid = ({
) : (
<ThemeProvider theme="inherit">
<Table<{ [P in keyof ITwinFull]: ITwinFull[P] }>
className={onThumbnailClick ? "row-cursor" : ""}
columns={columns}
data={iTwins}
onRowClick={onRowClick}
Expand All @@ -264,6 +263,7 @@ export const ITwinGrid = ({
onBottomReached={fetchMore}
autoResetFilters={false}
autoResetSortBy={false}
bodyProps={{ className: onThumbnailClick ? "row-cursor" : "" }}
/>
</ThemeProvider>
);
Expand Down
2 changes: 1 addition & 1 deletion packages/modules/imodel-browser/src/containers/iModelGrid/IModelGrid.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* See LICENSE.md in the project root for license terms and full copyright notice.
*--------------------------------------------------------------------------------------------*/
.rowCursor {
div[role="rowgroup"] div[role="row"] {
div[role="row"] {
cursor: pointer;
}
}
4 changes: 3 additions & 1 deletion packages/modules/imodel-browser/src/containers/iModelGrid/IModelGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ export const IModelGrid = ({
) : (
<ThemeProvider theme="inherit">
<Table<{ [P in keyof IModelFull]: IModelFull[P] }>
className={onThumbnailClick ? styles.rowCursor : ""}
columns={columns}
data={iModels}
onRowClick={onRowClick}
Expand Down Expand Up @@ -283,6 +282,9 @@ export const IModelGrid = ({
onBottomReached={fetchMore}
autoResetFilters={false}
autoResetSortBy={false}
bodyProps={{
className: onThumbnailClick ? styles.rowCursor : "",
}}
/>
</ThemeProvider>
)}
Expand Down