Fix imodel actions triggering onThumbnail click - #164
Merged
Conversation
arome
enabled auto-merge (squash)
July 10, 2025 23:26
DanishMehmood-bit
pushed a commit
that referenced
this pull request
Jul 29, 2025
* Vp/hide version feature (#2) * Added Hide version feature * Added the toaster for hide and unhide the named version * Added the unit tests * Fixed the row collapsing issue * Fixed test * Added disbleHideVersions props * Added the Prop to hide the feature * Added the chagnelog * Resolved the comments * Added the test for toogle switch * Test fixed * Added the timeout * Removed the unnecessary test steps * Added hidden icon column for the hidden Named versions (#1) * Add getBadge property on iModelTile in order to set badge based on iModel props (#162) * Update changelogs [skip ci] * Bump versions [skip ci] * Refactor IModelTile component to allow hovering over name label (#163) * Update changelogs [skip ci] * Bump versions [skip ci] * Fix imodel actions triggering onThumbnail click (#164) * Fix iModel actions opening imodel on click * Fix iModel opening issue in action dropdown * Update changelogs [skip ci] * Bump versions [skip ci] * Update itwinUI version in storybook (#165) * Update @itwin/itwinui-react to version 3.18.0 and import styles in Storybook preview * Fix broken storybook stories * Add update for itwinUI version in Storybook for @itwin/imodel-browser-react * tests for imodel tile (#166) * Add tests for IModelTile component and enhance accessibility with data-testid attributes * fix eslint error in storybook * Add tests for iModel tile in @itwin/imodel-browser-react * Update common/changes/@itwin/imodel-browser-react/omar-tests-for-imodel-tile_2025-07-11-17-33.json --------- Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * Add cellOverrides option to iModelGrid and iTwinGrid (#167) * Add cell overrides support to IModelGrid and related components * Add cell overrides support for IModelGrid and ITwinGrid components * Add cellOverrides option to iModelGrid and iTwinGrid * Enhance cellOverrides in IModelGrid and ITwinGrid with improved styling and icon updates * Update changelogs [skip ci] * Bump versions [skip ci] * Adding hidden icon column for Hidden named versions --------- Co-authored-by: Gintaras Volkvičius <17436829+GintV@users.noreply.github.com> Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com> Co-authored-by: Omar H <omar.halbouni@bentley.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> --------- Co-authored-by: Vivek Patil <Vivek.Patil@Bentley.com> Co-authored-by: SorexBentley <97873094+SorexBentley@users.noreply.github.com> Co-authored-by: Gintaras Volkvičius <17436829+GintV@users.noreply.github.com> Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com> Co-authored-by: Omar H <omar.halbouni@bentley.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> * Fixing review comments --------- Co-authored-by: Vivek Patil <Vivek.Patil@Bentley.com> Co-authored-by: SorexBentley <97873094+SorexBentley@users.noreply.github.com> Co-authored-by: Gintaras Volkvičius <17436829+GintV@users.noreply.github.com> Co-authored-by: imodeljs-admin <imodeljs-admin@users.noreply.github.com> Co-authored-by: Omar H <omar.halbouni@bentley.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My recent PR broke the iModel actions. Clicking on iModel actions would trigger the onThumbnail click.