Skip to content

Fix key release on 5-byte keypad frames and map M4 in pass-through - #260

Merged
iMicknl merged 2 commits into
mainfrom
fix-5-byte-keypad-release
Oct 28, 2026
Merged

iMicknl merged 2 commits into
mainfrom
fix-5-byte-keypad-release

Conversation

@iMicknl

@iMicknl iMicknl commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Since #208, the desk command sensor reads byte 5 as a second key byte for both 6-byte and 5-byte frames. On 5-byte keypads such as the HS01B-1 (#146) byte 5 is the checksum, so a release frame 9B 05 02 00 A1 60 9D decodes as ~16.33 instead of 8. In pass-through, Up/Down are then never released and keep moving until the min/max height.

Replaying frames through the decoder loop:

Frames Before After
5-byte up, release, down, release 1, 16.33, 2, 16.33 1, 8, 2, 8
6-byte up, release, M4, release 1, 8, 9, 8 1, 8, 9, 8

esphome config passes for both pass-through tests and the pass-through package; esphome compile tests/office-desk-esp32-passthrough.yaml succeeds.

Refs #146, #131, #152

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 28, 2026 00:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@iMicknl iMicknl added the bug Something isn't working label Oct 28, 2026
@iMicknl
iMicknl merged commit 79930d4 into main Oct 28, 2026
9 checks passed
@iMicknl
iMicknl deleted the fix-5-byte-keypad-release branch October 28, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants