Skip to content

fix issue.created bigint and number type mismatch error#156

Merged
iHildy merged 1 commit into
mainfrom
fix/bigint-github-webhook-error
Aug 16, 2025
Merged

fix issue.created bigint and number type mismatch error#156
iHildy merged 1 commit into
mainfrom
fix/bigint-github-webhook-error

Conversation

@iHildy

@iHildy iHildy commented Aug 16, 2025

Copy link
Copy Markdown
Owner

No description provided.

@iHildy iHildy merged commit d94e767 into main Aug 16, 2025
1 of 2 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @iHildy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a type mismatch error where GitHub IDs, which are typically represented as standard numbers, were incorrectly defined as bigint in the TypeScript interfaces and Zod schemas. The changes update these definitions to use the number type, ensuring consistency with GitHub's API responses and preventing potential data handling issues or runtime errors related to type discrepancies.

Highlights

  • Type Correction for Issue ID: The issue.id field in the GitHubLabelEvent interface and its corresponding Zod schema have been updated from bigint to number.
  • Type Correction for Repository ID: The repository.id field in the GitHubLabelEvent interface and its corresponding Zod schema have been updated from bigint to number.
  • Type Correction for GitHub Account ID: The id field in the GitHubAccount interface has been changed from bigint to number.
  • Type Correction for Webhook Repository ID: The id field in the GitHubWebhookRepository interface and its corresponding Zod schema have been updated from bigint to number.
  • Type Correction for Webhook Event IDs: The issue.id and repository.id fields within the GitHubWebhookEventSchema have been updated from z.bigint() to z.number().
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@iHildy iHildy deleted the fix/bigint-github-webhook-error branch August 16, 2025 20:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a type mismatch for GitHub entity IDs by changing them from bigint to number in TypeScript types and Zod schemas. This aligns with the data format from GitHub's API and prevents parsing errors. The change is consistently applied across the relevant files. I have one suggestion to restore some removed comments in src/types/github.ts to maintain code clarity.

Comment thread src/types/github.ts
Comment on lines +52 to +54
owner?: GitHubAccount;
private: boolean;
html_url?: string; // Optional for installation webhooks
html_url?: string;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These comments explaining why owner and html_url are optional were helpful. They clarified that these fields can be missing in installation-related webhooks. Restoring them would improve the maintainability and readability of this interface.

Suggested change
owner?: GitHubAccount;
private: boolean;
html_url?: string; // Optional for installation webhooks
html_url?: string;
owner?: GitHubAccount; // Optional for installation webhooks
private: boolean;
html_url?: string; // Optional for installation webhooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant