Skip to content

Conversation

@nabil-Tounarti
Copy link
Contributor

No description provided.

@nabil-Tounarti nabil-Tounarti self-assigned this Oct 23, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error handling in the pre-compute stage by collecting and returning all encountered errors instead of failing on the first error. This allows for more comprehensive error reporting and better debugging capabilities.

Key changes:

  • Modified read_args() to return both PreComputeArgs and a vector of errors instead of a single Result
  • Updated error collection to continue processing after encountering errors in dataset and input file handling
  • Enhanced PreComputeInputFileDownloadFailed error to include the file index

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pre-compute/src/compute/pre_compute_args.rs Changed read_args() to collect multiple errors during argument parsing and added comprehensive tests for error collection scenarios
pre-compute/src/compute/pre_compute_app.rs Updated run() and download_input_files() to collect errors instead of early returns, allowing continued processing
pre-compute/src/compute/errors.rs Modified PreComputeInputFileDownloadFailed to include file index for better error identification
pre-compute/src/compute/app_runner.rs Updated error handling to work with vector of causes instead of single cause

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nabil-Tounarti nabil-Tounarti merged commit 2d55149 into main Oct 29, 2025
7 checks passed
@nabil-Tounarti nabil-Tounarti deleted the feature/bulk-processing branch October 29, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants