-
Couldn't load subscription status.
- Fork 0
feat: Return all bulk dataset processing errors #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…plicateStatusCause>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances error handling in the pre-compute stage by collecting and returning all encountered errors instead of failing on the first error. This allows for more comprehensive error reporting and better debugging capabilities.
Key changes:
- Modified
read_args()to return bothPreComputeArgsand a vector of errors instead of a singleResult - Updated error collection to continue processing after encountering errors in dataset and input file handling
- Enhanced
PreComputeInputFileDownloadFailederror to include the file index
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pre-compute/src/compute/pre_compute_args.rs | Changed read_args() to collect multiple errors during argument parsing and added comprehensive tests for error collection scenarios |
| pre-compute/src/compute/pre_compute_app.rs | Updated run() and download_input_files() to collect errors instead of early returns, allowing continued processing |
| pre-compute/src/compute/errors.rs | Modified PreComputeInputFileDownloadFailed to include file index for better error identification |
| pre-compute/src/compute/app_runner.rs | Updated error handling to work with vector of causes instead of single cause |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.