Skip to content

Commit

Permalink
Update Jetpack Lifecycle to 2.2.0 (stripe#2120)
Browse files Browse the repository at this point in the history
Summary
`ViewModelProviders.of()` has been deprecated in favor
of `ViewModelProvider`

See the release notes for more details [0]

[0] https://developer.android.com/jetpack/androidx/releases/lifecycle#version_220_3

Testing
Manually verified
  • Loading branch information
mshafrir-stripe authored Jan 30, 2020
1 parent f4e5230 commit 51dde13
Show file tree
Hide file tree
Showing 11 changed files with 19 additions and 20 deletions.
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ ext {
javaAnnotationVersion = '1.0'
kotlinVersion = '1.3.61'
kotlinCoroutinesVersion = '1.3.0'
androidLifecycleVersion = '2.2.0'
espressoVersion = '3.2.0'
ktlintVersion = '0.36.0'

Expand Down
3 changes: 1 addition & 2 deletions example/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ dependencies {
implementation 'androidx.multidex:multidex:2.0.1'
implementation 'androidx.appcompat:appcompat:1.1.0'
implementation 'androidx.recyclerview:recyclerview:1.1.0'
implementation "androidx.lifecycle:lifecycle-viewmodel:2.1.0"
implementation 'androidx.lifecycle:lifecycle-extensions:2.1.0'
implementation "androidx.lifecycle:lifecycle-viewmodel:$androidLifecycleVersion"
implementation 'com.google.android.material:material:1.1.0-rc02'

implementation 'com.google.android.gms:play-services-wallet:18.0.0'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import android.view.View
import androidx.appcompat.app.AlertDialog
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import androidx.recyclerview.widget.LinearLayoutManager
import com.stripe.android.ApiResultCallback
import com.stripe.android.PaymentConfiguration
Expand All @@ -25,7 +25,7 @@ import kotlinx.android.synthetic.main.activity_card_sources.*
*/
class CreateCardSourceActivity : AppCompatActivity() {
private val viewModel: SourceViewModel by lazy {
ViewModelProviders.of(this)[SourceViewModel::class.java]
ViewModelProvider(this)[SourceViewModel::class.java]
}
private val sourcesAdapter: SourcesAdapter by lazy {
SourcesAdapter()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import androidx.lifecycle.AndroidViewModel
import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import com.stripe.android.ApiResultCallback
Expand Down Expand Up @@ -41,7 +41,7 @@ class CreateCardTokenActivity : AppCompatActivity() {
orientation = LinearLayoutManager.VERTICAL
}

val viewModel = ViewModelProviders.of(
val viewModel = ViewModelProvider(
this
)[CreateCardTokenViewModel::class.java]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import android.view.View
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.LiveData
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import com.stripe.android.ApiResultCallback
import com.stripe.android.Stripe
import com.stripe.android.model.Address
Expand All @@ -19,7 +19,7 @@ import kotlinx.android.synthetic.main.activity_klarna_source.*

class KlarnaSourceActivity : AppCompatActivity() {
private val viewModel: SourceViewModel by lazy {
ViewModelProviders.of(this)[SourceViewModel::class.java]
ViewModelProvider(this)[SourceViewModel::class.java]
}

private val stripe: Stripe by lazy {
Expand Down
3 changes: 1 addition & 2 deletions stripe/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ dependencies {
implementation 'androidx.annotation:annotation:1.1.0'
implementation 'androidx.appcompat:appcompat:1.1.0'
implementation 'androidx.recyclerview:recyclerview:1.1.0'
implementation "androidx.lifecycle:lifecycle-viewmodel:2.1.0"
implementation 'androidx.lifecycle:lifecycle-extensions:2.1.0'
implementation "androidx.lifecycle:lifecycle-viewmodel:$androidLifecycleVersion"
implementation 'androidx.localbroadcastmanager:localbroadcastmanager:1.0.0'

// Api for this import because we use reflection to alter TextInputLayout
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import androidx.annotation.StringRes
import androidx.core.text.util.LinkifyCompat
import androidx.core.view.ViewCompat
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import com.stripe.android.CustomerSession
import com.stripe.android.PaymentConfiguration
import com.stripe.android.R
Expand Down Expand Up @@ -60,7 +60,7 @@ class AddPaymentMethodActivity : StripeActivity() {
}

private val viewModel: AddPaymentMethodViewModel by lazy {
ViewModelProviders.of(this, AddPaymentMethodViewModel.Factory(
ViewModelProvider(this, AddPaymentMethodViewModel.Factory(
stripe, customerSession, args
))[AddPaymentMethodViewModel::class.java]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import androidx.appcompat.widget.AppCompatImageView
import androidx.core.widget.ImageViewCompat
import androidx.fragment.app.FragmentActivity
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import androidx.recyclerview.widget.DefaultItemAnimator
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
Expand Down Expand Up @@ -52,7 +52,7 @@ internal class AddPaymentMethodFpxView @JvmOverloads internal constructor(
itemAnimator = DefaultItemAnimator()
}

viewModel = ViewModelProviders.of(
viewModel = ViewModelProvider(
activity,
FpxViewModel.Factory(activity.application)
).get(FpxViewModel::class.java)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import android.view.MenuItem
import androidx.annotation.ColorInt
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import androidx.localbroadcastmanager.content.LocalBroadcastManager
import com.stripe.android.Logger
import com.stripe.android.PaymentAuthWebViewStarter
Expand All @@ -34,7 +34,7 @@ class PaymentAuthWebViewActivity : AppCompatActivity() {
return
}

viewModel = ViewModelProviders.of(
viewModel = ViewModelProvider(
this, PaymentAuthWebViewActivityViewModel.Factory(args)
)[PaymentAuthWebViewActivityViewModel::class.java]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import android.app.Activity
import android.content.Intent
import android.os.Bundle
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import androidx.viewpager.widget.ViewPager
import com.stripe.android.CustomerSession
import com.stripe.android.PaymentSession.Companion.EXTRA_PAYMENT_SESSION_DATA
Expand Down Expand Up @@ -44,7 +44,7 @@ class PaymentFlowActivity : StripeActivity() {
viewStub.layoutResource = R.layout.activity_shipping_flow
viewStub.inflate()

viewModel = ViewModelProviders.of(
viewModel = ViewModelProvider(
this,
PaymentFlowViewModel.Factory(customerSession, args.paymentSessionData)
)[PaymentFlowViewModel::class.java]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import android.view.View
import androidx.annotation.StringRes
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProviders
import androidx.lifecycle.ViewModelProvider
import com.google.android.material.snackbar.Snackbar
import com.stripe.android.CustomerSession
import com.stripe.android.PaymentSession.Companion.TOKEN_PAYMENT_SESSION
Expand Down Expand Up @@ -46,7 +46,7 @@ class PaymentMethodsActivity : AppCompatActivity() {
}

private val viewModel: PaymentMethodsViewModel by lazy {
ViewModelProviders.of(
ViewModelProvider(
this,
PaymentMethodsViewModel.Factory(customerSession, args.initialPaymentMethodId)
)[PaymentMethodsViewModel::class.java]
Expand Down

0 comments on commit 51dde13

Please sign in to comment.