don't check ollama connection on linux #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomas2D
reviewed
Jan 17, 2025
Signed-off-by: Paul S. Schweigert <[email protected]> Configuring docker on linux to connect to ollama requires making edits in the bee-api container's /etc/hosts file once all pods are up and running. As a result, for linux users the `configure_ollama` command will always fail. This PR skips the ollama connection check for linux users
psschwei
force-pushed
the
linux-setup-script
branch
from
7f98835 to
b2f76f2
Compare
|
I think I'm addressing this in #81 |
|
please see my comment in the other issue: Can we just try |
I think we'll still need both -- this check runs during setup (i.e. creating the .env file), while your PR fixes the startup (i.e. when the containers are actually run). |
I left a comment on the other PR, but the TLDR is no, I don't think extra_hosts will work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul S. Schweigert [email protected]
Configuring docker on linux to connect to ollama requires making edits in the bee-api container's /etc/hosts file once all pods are up and running. As a result, for linux users the
configure_ollamacommand will always fail.This PR skips the ollama connection check for linux users